-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump gradle 6.9.2 -> 8.2.1 #49
Conversation
Checks are failing, but it looks like they were failing before...? |
Is this possibly related to the failing test? It appears to try and fetch a client certificate to authenticate against the drive API with. CrashReporter/cr-core/src/main/java/org/terasology/crashreporter/logic/GoogleDriveConnector.java Lines 179 to 191 in 9d16957
|
Good find @BenjaminAmos ! |
Temp Jenkins is pretty basic and I did not cover much stuff that seemed secondary or tertiary - I wasn't even sure if that file was in use still, I did spot it just the other day when going through the InfraPlayground repo wondering what's needed and what to even automate. I'm not even sure what it makes sense to let the CR support - the few times we got a (working) use of the GDrive integration it was awkward vs pastebin since you had to go download a file, extract, and view logs locally. It may make more sense to retire it and focus on pastebin In any case there's a tiny readme section over at https://github.com/MovingBlocks/InfraPlayground/tree/master/jenkins/cbc#setup-google-drive-serviceaccount-key with the file living in the same directory. Even though we don't use the CBC Jenkins now it doesn't look too complex to sort out and port over, but the big question (to me) remains: should we? |
Just tested it via the engine repo and it tests out fine. But as I'm the author of this PR, I cannot approve it. |
Relates to MovingBlocks/Terasology#5109
Relates to MovingBlocks/Terasology#4653
Contains
How to test
groovyw lib get CrashReporter
libs/CrashReporter
check out this branchRemarks
Java 20 is not yet supported, see gradle/gradle#23488.