Skip to content

Upgrade Node.js to version 24#8

Merged
Mouette03 merged 11 commits into
mainfrom
Node24
Mar 26, 2026
Merged

Upgrade Node.js to version 24#8
Mouette03 merged 11 commits into
mainfrom
Node24

Conversation

@Mouette03

@Mouette03 Mouette03 commented Mar 26, 2026

Copy link
Copy Markdown
Owner

This pull request updates the project to use Node.js 24 throughout the development and production environments. The changes ensure consistency across the Docker setup, GitHub Actions workflow, and backend dependencies.

Node.js version upgrade:

  • Updated the base Node.js version in all Dockerfile stages (frontend-builder, backend-builder, and runner) from 20 to 24 to standardize the build and runtime environments. [1] [2] [3]
  • Changed the Node.js version used in the GitHub Actions workflow (.github/workflows/docker.yml) from 20 to 24 for CI/CD consistency.

Backend dependency updates:

  • Increased the required Node.js and npm versions in backend/package.json to >=24.0.0 and >=11.0.0 respectively, ensuring compatibility with the new environment.
  • Updated the @types/node development dependency in backend/package.json to version ^24.0.0 to match the new Node.js version.

Summary by CodeRabbit

Mises à jour

  • Chores
    • Mise à niveau de Node.js vers la v24 dans l’environnement de build et les images de runtime.
    • Exigences minimales relevées : Node.js >=24.0.0 et npm >=11.0.0.
    • Champ d’exécution ajouté au frontend pour exiger Node.js >=24.0.0.
    • Mise à jour des définitions de types de Node pour la compatibilité v24.

Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
@coderabbitai

coderabbitai Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f03d2156-b6f6-462c-845a-9333750c870c

📥 Commits

Reviewing files that changed from the base of the PR and between 9044640 and 0bf460d.

📒 Files selected for processing (1)
  • frontend/package.json
✅ Files skipped from review due to trivial changes (1)
  • frontend/package.json

📝 Walkthrough

Walkthrough

Mise à jour de la version de Node.js de 20 à 24 dans les workflows GitHub Actions et les stages Docker, plus alignement des contraintes engines dans backend/package.json et ajout de engines dans frontend/package.json ; mise à jour des types Node en devDependencies.

Changes

Cohort / File(s) Summary
CI workflow
.github/workflows/docker.yml
Changement de node-version: "20"node-version: "24" dans le job lint.
Docker build
Dockerfile
Remplacement des images de base Node.js de 20 par 24 pour frontend-builder, backend-builder et runner.
Backend package
backend/package.json
Bump de enginesnode: ">=24.0.0", npm: ">=11.0.0" ; mise à jour de devDependencies @types/node^24.0.0.
Frontend package
frontend/package.json
Ajout du champ engines.node">=24.0.0".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 Vingt était bon, mais vingt-quatre me plaît,
De Docker à CI mon cœur fait un saut,
Les engines s'alignent, tout est prêt,
Un petit bond dans le code, tout en sautillant,
Hop—voici la mise à jour, et je me régale ! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Le titre décrit clairement le changement principal : la mise à niveau de Node.js à la version 24, qui correspond exactement aux modifications apportées dans tous les fichiers (Dockerfile, workflows GitHub Actions, et package.json).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Node24

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
Dockerfile (1)

10-37: Cohérence : envisager d'ajouter la contrainte engines dans frontend/package.json.

Le backend/package.json déclare "engines": { "node": ">=24.0.0" }, mais le frontend n'a apparemment pas cette contrainte. Pour garantir la cohérence entre les environnements de build et éviter des problèmes de compatibilité, ajoutez la même contrainte engines dans frontend/package.json.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile` around lines 10 - 37, Add the same Node engine constraint to the
frontend package manifest to match the backend: open frontend/package.json and
add an "engines" field with "node": ">=24.0.0" (same as backend/package.json) so
builds use a consistent Node version; update any package.json validation or CI
that reads engines if present to ensure the frontend build respects the
constraint.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Dockerfile`:
- Around line 10-37: Add the same Node engine constraint to the frontend package
manifest to match the backend: open frontend/package.json and add an "engines"
field with "node": ">=24.0.0" (same as backend/package.json) so builds use a
consistent Node version; update any package.json validation or CI that reads
engines if present to ensure the frontend build respects the constraint.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8a3abf38-d126-43d3-80f3-6756ee35c0ea

📥 Commits

Reviewing files that changed from the base of the PR and between 0421fc4 and 9044640.

📒 Files selected for processing (3)
  • .github/workflows/docker.yml
  • Dockerfile
  • backend/package.json

Signed-off-by: Damien <mouette03@yahoo.fr>
@Mouette03 Mouette03 merged commit abcd9de into main Mar 26, 2026
1 check passed
@Mouette03 Mouette03 deleted the Node24 branch April 4, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant