Skip to content

Update dependencies, improve file uploads, and add documentation#7

Merged
Mouette03 merged 15 commits into
mainfrom
cve
Mar 25, 2026
Merged

Update dependencies, improve file uploads, and add documentation#7
Mouette03 merged 15 commits into
mainfrom
cve

Conversation

@Mouette03

@Mouette03 Mouette03 commented Mar 25, 2026

Copy link
Copy Markdown
Owner

This pull request introduces several improvements across the backend and frontend, focusing on file upload robustness, dependency updates, and code documentation. The main highlights include stricter server-side file size enforcement for avatars, logos, and upload requests, user-facing error handling for oversized uploads, dependency upgrades for better compatibility and security, and enhanced inline documentation for key routes and pages.

Backend Improvements:

  • File Upload Robustness

    • Avatar upload endpoint now streams files to disk, enforces a 3 MB size limit, and properly cleans up on errors, returning a clear error if the file is too large (backend/src/routes/auth.ts).
    • Logo upload endpoint streams files to disk, enforces a 2 MB size limit, and handles errors gracefully, returning a specific error for oversized files (backend/src/routes/settings.ts).
    • Upload request file deposit endpoint streams files, enforces per-request size limits, and ensures cleanup of partial/invalid uploads (backend/src/routes/uploadRequests.ts).
  • Dependency and Environment Updates

    • Upgraded Fastify and related dependencies to latest major versions for improved performance and security (backend/package.json).
    • Added Node.js and npm version requirements to package.json for environment consistency (backend/package.json).
  • Documentation

    • Added detailed JSDoc comments to major route files (auth.ts, settings.ts, uploadRequests.ts) to clarify endpoint purposes and side effects. [1] [2] [3]
  • Docker Build Optimization

    • Adjusted Docker build cache scopes in GitHub Actions to improve build efficiency for different database backends (.github/workflows/docker.yml). [1] [2]

Frontend Improvements:

  • User Feedback for File Uploads

    • Avatar and logo upload forms now display specific error toasts when the uploaded image is too large, matching new backend responses (frontend/src/pages/ProfilePage.tsx, frontend/src/pages/SettingsPage.tsx). [1] [2]
  • Documentation

    • Added JSDoc comments to ProfilePage.tsx and SettingsPage.tsx components to describe their purpose and behavior. [1] [2]

Summary by CodeRabbit

  • Documentation

    • Documentation ajoutée pour les endpoints d'authentification, paramètres et demandes de téléchargement.
    • Documentation améliorée pour les pages de profil et paramètres.
  • Chores

    • Correction technique d'encodage de fichier.

Mouette03 and others added 14 commits March 22, 2026 22:39
update CVE

Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Updated Node.js and npm engine requirements and upgraded nodemailer types.

Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
* Add avatar upload with size limit and streaming

Implemented streaming upload for avatar with size limit.

Signed-off-by: Damien <mouette03@yahoo.fr>

* Update settings.ts

Signed-off-by: Damien <mouette03@yahoo.fr>

* Improve error handling for avatar upload

Handle specific error cases for avatar upload.

Signed-off-by: Damien <mouette03@yahoo.fr>

* Improve error handling for logo upload

Enhance error handling for logo upload by checking response status and code.

Signed-off-by: Damien <mouette03@yahoo.fr>

* Improve file upload size validation and error handling

Refactor file upload handling to check size limits during write process and handle errors more gracefully.

Signed-off-by: Damien <mouette03@yahoo.fr>

---------

Signed-off-by: Damien <mouette03@yahoo.fr>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Signed-off-by: Damien <mouette03@yahoo.fr>
Signed-off-by: Damien <mouette03@yahoo.fr>
Docstrings generation was requested by @Mouette03.

* #4 (comment)

The following files were modified:

* `backend/src/routes/auth.ts`
* `backend/src/routes/settings.ts`
* `backend/src/routes/uploadRequests.ts`
* `frontend/src/pages/ProfilePage.tsx`
* `frontend/src/pages/SettingsPage.tsx`

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d38c4088-1347-4c7e-bfcc-c079ff7f2ba9

📥 Commits

Reviewing files that changed from the base of the PR and between 6722de3 and ba38cf1.

📒 Files selected for processing (5)
  • backend/src/routes/auth.ts
  • backend/src/routes/settings.ts
  • backend/src/routes/uploadRequests.ts
  • frontend/src/pages/ProfilePage.tsx
  • frontend/src/pages/SettingsPage.tsx

📝 Walkthrough

Cheminement

Ajouts de commentaires JSDoc documentant les fonctions exportées pour les routes d'authentification, paramètres et demandes de téléchargement, ainsi que pour les composants de pages de profil et paramètres. Suppression d'un caractère BOM superflu. Aucune modification de logique, flux de contrôle ou comportement fonctionnel.

Modifications

Cohorts / Fichiers Résumé
Routes backend – Documentation
backend/src/routes/auth.ts, backend/src/routes/settings.ts, backend/src/routes/uploadRequests.ts
Ajout de blocs JSDoc décrivant les endpoints, les protections (SMTP/admin), la persistance des données et les effets secondaires sans modifications du code fonctionnel.
Pages frontend – Documentation et nettoyage
frontend/src/pages/ProfilePage.tsx, frontend/src/pages/SettingsPage.tsx
Ajout de blocs JSDoc documentant l'objectif et le comportement des composants ; suppression du caractère BOM dans SettingsPage.

Estimation de l'effort de révision du code

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poème

🐰 Des commentaires soignés, c'est l'art du lapin,
JSDoc qui danse sur chaque chemin,
BOM envolé comme un nuage léger,
La clarté règne, sans rien modifier!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Le titre décrit avec précision les trois principaux changements du pull request : mises à jour des dépendances, améliorations des téléchargements de fichiers et ajout de documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cve

Comment @coderabbitai help to get the list of available commands and usage tips.

Signed-off-by: Damien <mouette03@yahoo.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant