Skip to content

(GitHub Toggle Issue Comments) Reference messages are not listed/hidden #28

Closed
@darkred

Description

@darkred

Using 'GitHub Toggle Issue Comments' script version 1.1.2
with GM 3.17 in Firefox 56.01

Example link:
https://github.com/Microsoft/vscode/issues/11847
There are 3 such entries in that page (one is a group with 3 entries, the other two are single) .

I quote from the script code:

refs: {
	isHidden: false,
	name: "ghic-refs",
	selector: ".discussion-item-ref, .discussion-item-head_ref_deleted",
	label: "References"
},

Unfortunately the above selector .discussion-item-ref, .discussion-item-head_ref_deleted no longer works:
these entries now have a single class name instead, the plain: .discussion-item, as I noticed.
This class name is also given (among others) to other entries.
@Mottie, if that helps you, I think that a simple way to identify such entries is to check if their .className === 'discussion-item' && .classList.length === 1 .


PS. Btw, I've checked most other entry times (in other issue pages) and they all still work ok (I didn't find appropriate issue pages to check the: Integrations and the 'Diff current/outdated' entries)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions