(GitHub diff files filter) Only «all» button seems to do anything

[daaain]

I installed the GitHub diff files filter on Firefox with Tampermonkey.

When looking at a PR all the buttons are correctly rendered (ie file extensions and folders are picked up), but toggling anything other than the «all» button doesn't do anything.

How can I debug it?

[Mottie]

Hi @daaain!

Hmm, yeah that seems to have stopped working. I probably won't be able to work on this until the weekend.

As for debugging... it looks like GitHub removed the file anchors which were being used to target the file blocks - see https://github.com/Mottie/GitHub-userscripts/blob/master/github-diff-files-filter.user.js#L75. The userscript is using the unique SHA to target each file. It looks like it could be switched to the div id instead.

[daaain]

Yes, this works!

group.forEach(file_div_id => {
  const file = $(`#${file_div_id}`, files);
  if (file) {
    file.classList.toggle(`gdf-${subgroup}-hidden`, !show);
  }
});

Correction: it works for extensions, but doesn't work for folders 😿

Edit: OK, so this seems to fix the folders toggle:

if (folders[folder].length && !folder.includes("→")) {
  acc.push({
    folder,
    show: $(`.gdf-folder-filter a[data-item=${folder}]`).classList.contains(
      "selected"
    )
  });
}

It's basically throwing an error when trying to have a selector for moved files, filtering using the arrow does the trick, though I guess there might be a nicer way to do it.