Skip to content

Conversation

MaksymKapelianovych
Copy link
Contributor

This will force node to rebuild its pins if only PinFriendlyName is changed.

@jnucc
Copy link
Contributor

jnucc commented May 12, 2025

We did a very similar change on our side, so the need is there !

There is another CheckPinsMatch(const TArray<UEdGraphPin*>& GraphPins, const TArray<FFlowPin>& NodePins) below, I wonder if we need to do the same thing inside the ContainsByPredicate() call ?

@MothDoctor MothDoctor self-assigned this May 15, 2025
@MaksymKapelianovych
Copy link
Contributor Author

MaksymKapelianovych commented May 15, 2025

Interesting question, I am not sure) Can you provide, please, a test case if you have any, so I could reproduce this issue on my side? @jnucc
Because I never encountered any issues with that particular function.
Of course we can add check for PinFriendlyName just in case, it shouldn't make any additional problems.

@MaksymKapelianovych
Copy link
Contributor Author

MaksymKapelianovych commented May 15, 2025

Actually, now when I am looking at the code, looks like that function is redundant and we can just delete it 🤔
But maybe I am missing something

@jnucc
Copy link
Contributor

jnucc commented May 15, 2025

Nah you can forget about the other function below, I'm not all that familiar with all the inner workings of FlowGraph, please ignore. :-)

@MaksymKapelianovych
Copy link
Contributor Author

No no no, that was actually a very valid point. That function also has to be changed and test case is setting pins with friendly names in node constructor. When I made this PR I didn't notice that TryUpdateNodePins refreshes context pins, but not default pins. There is definitely the issue, so thank you for pointing that out)

@MothDoctor MothDoctor force-pushed the 5.x branch 2 times, most recently from 2d2ccdc to 223d190 Compare May 15, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants