Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added request_id to message for client testing #63

Merged
merged 2 commits into from
Oct 22, 2024
Merged

added request_id to message for client testing #63

merged 2 commits into from
Oct 22, 2024

Conversation

arkanoider
Copy link
Collaborator

@grunch @bilthon ,

added an u64 named request_id in messages of mostro-core to evaluate the delay noticed in client interfaces.

pub struct MessageKind {
    /// Message version
    pub version: u8,
    /// Request_id for test on client
    pub request_id: u64,
    /// Message id is not mandatory
    #[serde(skip_serializing_if = "Option::is_none")]
    pub id: Option<Uuid>,
    /// Action to be taken
    pub action: Action,
    /// Message content
    pub content: Option<Content>,
}

@grunch grunch marked this pull request as ready for review October 22, 2024 13:39
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grunch grunch merged commit d87f4bf into main Oct 22, 2024
1 check passed
@grunch grunch deleted the bilthon-test branch October 22, 2024 17:53
@arkanoider
Copy link
Collaborator Author

arkanoider commented Oct 22, 2024

uhhh mreged in main? We will keep this in the main mostro trunk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants