Comprehensively update DOCUMENTATION.md for accuracy and completeness#12
Merged
MostCromulent merged 1 commit intoYieldReworkfrom Jan 29, 2026
Merged
Conversation
Applied 10 amendments to improve documentation quality:
CRITICAL FIXES:
1. Add missing YieldController.java to file lists and architecture
- YieldController is a core component that was completely missing
- Updated "New Files" section from 3 to 4 files
2. Add comprehensive Architecture section
- Component hierarchy diagram showing GUI layer organization
- Detailed explanation of YieldController, AbstractGuiGame interaction
- Network independence architecture with multi-player scenarios
- Complete data flow diagrams for all yield operations
- File organization with clear component responsibilities
MODERATE IMPROVEMENTS:
3. Expand State Management section with delegation pattern
- Show AbstractGuiGame's lazy initialization of YieldController
- Document YieldCallback interface implementation
- Add complete state map documentation from YieldController
- Include mode-specific end condition table
4. Correct Modified Files count and descriptions
- Updated from 14 to 13 files (removed EDocID, FButton, ProtocolMethod)
- Improved descriptions to match actual implementation
- Clarified that network protocol has no yield-specific changes
MINOR ENHANCEMENTS:
5. Clarify Yield Options Panel button layout
- Document 2-row layout structure
- Add visual feedback section
- Note cleanup/discard phase button disabling
6. Add PlayerView lookup technical detail
- Document TrackableTypes.PlayerViewType.lookup() usage
- Explain Map key consistency requirement
7. Expand Smart Yield Suggestions section
- Add preference names for each suggestion type
- Document auto-suppression behavior in detail
- Clarify when suggestions appear vs. don't appear
- Explain yield button priority over suggestions
8. Add Initial Implementation changelog entry
- Document YieldController architecture rationale
- Explain delegate and callback pattern choices
- Note lazy initialization strategy
9. Fix typo: Make "disabled" bold for clarity in interrupt section
10. Add comprehensive Troubleshooting section
- Yield activation issues
- Unexpected yield clearing
- Smart suggestion behavior
- Network play expectations
- Performance considerations
The documentation now accurately reflects the codebase implementation,
includes the requested Architecture section explaining component
interactions, and provides helpful troubleshooting guidance for users.
https://claude.ai/code/session_01SBGxSAqnqbpVuEsinNtrnZ
MostCromulent
added a commit
that referenced
this pull request
Jan 30, 2026
Analyzer improvements: - Add FailureMode enum (NONE, TIMEOUT, CHECKSUM_MISMATCH, EXCEPTION, INCOMPLETE) - Track first error turn for each game - Add failure mode classification based on log content - Add error frequency analysis with normalization for grouping - Add batch performance tracking (10 games per batch) - Add turn distribution histogram for detecting early terminations - Add failure pattern metrics (consecutive failures, half-to-half comparison) - Add stability trend detection (STABLE vs DEGRADING) New report sections: - Turn Distribution table with early termination warnings - Failure Mode Analysis with affected games - Batch Performance with per-batch success rates - Top Errors by frequency - Failure Patterns with stability trend Bug fixes: - Fix timestamp extraction for new log filename format (run prefix) - Fix timestamp filtering to include same-second logs Add CLAUDE.md and .claude/ configuration to repository for session continuity. Document Bug #12 (multiplayer desync) for investigation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MostCromulent
added a commit
that referenced
this pull request
Jan 30, 2026
Bug #12: Collection lookup failures in 3+ player games - Split object creation into two phases in NetworkGuiGame.applyDelta() - Phase 1a: Create all objects and register in tracker - Phase 1b: Apply properties (cross-references now work) - Added createObjectOnly() method for phase separation - Fixed type name logging in NetworkTrackableDeserializer Bug Card-Forge#13: Checksum mismatch due to player ordering - Sort players by ID before computing checksum in DeltaSyncManager - Sort players by ID before computing checksum in NetworkGuiGame - Ensures consistent iteration order between server and client Also fixed: - Log file overwrites by adding batch number to filenames - Updated log analyzer regex patterns for new naming format Test results: 100% success rate, 0 checksum mismatches Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MostCromulent
added a commit
that referenced
this pull request
Jan 30, 2026
Merges all code changes from dev branch excluding: - testlogs/ (test artifacts) - .documentation/ (internal docs) - CLAUDE.md, .claude/ (AI assistant config) Key changes included: - Network debug logs now save to user directory (networklogs/) - PreferencesStore pattern for network debug config - Server-side AI option for multiplayer testing - Multiplayer desync bug fixes (#12, Card-Forge#13) - Enhanced test infrastructure and analysis tools Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
MostCromulent
added a commit
that referenced
this pull request
Feb 2, 2026
- Fix Bug #12/13 references in Debugging.md to prevent auto-linking - Fix stray "2" at beginning of .gitignore Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.