While using KarmaTestAdapter, the failed unit test not showing as failed in visual studio

[mstephano]

Hi,

I am using KarmaTestAdapter, and my failed Jasmine unit test was showing under "Not Run Tests" in the Test Explorer of Visual Studio 2013. Selecting the test and trying to "Run Selected Tests" was doing nothing in Visual Studio, not even showing the Karma error message in the bottom part of Test Explorer.

So I had to debug KarmaTestAdapter, the bug is in JsTestAdapter under "JsTestAdapter.TestAdapter.TestRunner.GetResult()" line 222. It seams that failure.stack is null, so the fix is to replace line 222 to this:

testResult.ErrorStackTrace = string.Join(Environment.NewLine, failure.stack ?? (new List<string>()));

Also, line 226 gave me an error because extraFailure.stack is also null, so replace line 226 to this:

string.Join(Environment.NewLine, extraFailure.message, string.Join(Environment.NewLine, extraFailure.stack ?? (new List<string>())))

I deployed the fix locally and it worked. Can you please fix it and make a new redistribution package? My whole team is using your Extension (thank you very much for that) and the fix can probably help others than only my team.

Best regards!

[peabnuts123]

Do you want to commit to a fork? Then I will check it out too. Then we could probably get a pull request going

[mstephano]

Hi peabnuts123, I am very new to GitHub, in fact, my last post is my first and only post here. I would feel more confident if someone else does the fix. But if there is no volunteer, I can try to check it out and commit it.

[peabnuts123]

Always a good time to learn right :p Otherwise I can perhaps find some time to make a fork and push to it. If you are familiar with git itself then it is a very straightforward process.

If the original author has totally abondoned the repos then I guess we could a true fork and just develop against that instead.

[mstephano]

Alright, I just read about how to fork and then pull request, nothing too complicated. However, I will not be able to make the changes tonight, but more by tomorrow lunch time.

If you really are in a hurry to test my fix, please do the fork and push and give me instructions on how i can test your changes (if you need a tester of course).

[mstephano]

Hi peabnuts123, I managed to fork and commit my change in my local repository. Any idea how we can test this? Because JsTestAdapter is a nuget package, so I will need to deploy my own package in nuget, and then reference it in my local repository of KarmaTestAdapter?

You can find my commit here: mstephano@304fe8b

[celluj34]

@mstephano is it alright if I create a new PR from your changes? I will reference this issue and the fix from your repo.

[mstephano]

there is no problem with me. Please go ahead, I will learn from all this process of GitHub and will do it on my own next time.

[mstephano]

Any idea how the KarmaTestAdapter will be rebuilt with this fix?

In case anyone would like to test, I deployed the fix version in Nuget under https://www.nuget.org/packages/JsTestAdapterFix/. I already tried this version in my local fork of KarmaTestAdapter, and managed to package into a distributable .vsix, and everything is fine for me and my collegues. Just need other people to see if it does fix their issue.