Update tooltip.js positionTooltip #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update `positionTooltip` fn to apply the proper class to tooltips/popovers when using "auto" placement determination - now if a popover with "auto right" ends up being calculated to the left, the popover will receive the correct `left` class, and not `right`
Morgul
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a "simple" fix to address an issue I noticed with tooltip/popover positioning for "auto" placement. This also fixes the arrow to show up on the correct side, as it's based on the class applied to the popover for example.
Not sure if there is a cleaner way to do this, but this seems to work well.
Changes
positionTooltipfn to apply the proper class to tooltips/popovers when using "auto" placement determinationleftclass, and notright.