Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing wei type in format type #881

Closed

Conversation

trietsipher
Copy link


Missing wei type in format type)

Hi guys, I used the API (https://docs.moralis.io/reference/getnfttrades) but the response data in the field price is different between API and SDK because it misses the 'wei' like other files.
Could you guys help me double-check it, thank you so much

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2022

🦋 Changeset detected

Latest commit: c3cc5b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@moralisweb3/common-evm-utils Patch
@moralisweb3/api-utils Patch
@moralisweb3/auth Patch
@moralisweb3/evm-api Patch
@moralisweb3/evm-utils Patch
moralis Patch
@moralisweb3/streams Patch
@moralisweb3/common-auth-utils Patch
@moralisweb3/common-streams-utils Patch
@moralisweb3/client-evm-api Patch
@moralisweb3/client-firebase-evm-api Patch
@moralisweb3/codegen Patch
@moralisweb3/next Patch
@moralisweb3/parse-server Patch
@moralisweb3/sol-api Patch
@moralisweb3/sol-utils Patch
@moralisweb3/test-utils Patch
@moralisweb3/common-core Patch
@moralisweb3/common-sol-utils Patch
@moralisweb3/client-api-utils Patch
@moralisweb3/client-firebase-api-utils Patch
@moralisweb3/client-firebase-auth-utils Patch
@moralisweb3/client-firebase-evm-auth Patch
@moralisweb3/client-firebase-sol-api Patch
@moralisweb3/client-firebase-sol-auth Patch
@moralisweb3/client-sol-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@b4rtaz
Copy link
Collaborator

b4rtaz commented Dec 8, 2022

Hi @trietsipher! Thank you for your contribution! This pull request fails on the prettier step. Also we needed to fix integration tests, that's why I've created a new PR. So I close this PR.

@b4rtaz b4rtaz closed this Dec 8, 2022
@trietsipher
Copy link
Author

@b4rtaz My pleasure, and thanks for letting me know 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants