Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: bugfix #859

Merged
merged 3 commits into from
Nov 29, 2022
Merged

next: bugfix #859

merged 3 commits into from
Nov 29, 2022

Conversation

Y0moo
Copy link
Contributor

@Y0moo Y0moo commented Nov 29, 2022


name: 'Pull request'
about: Bug fix @moralisweb3/next

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

  • Using Moralis DataTypes as hook params leads to infinite rerenders
  • Request challenge hooks fetch data with wrong behavior

Solution

  • serialize requests before passing them to the useSWR hooks
  • set fetcher null when no params provided to the hook

@Y0moo Y0moo self-assigned this Nov 29, 2022
@changeset-bot
Copy link

changeset-bot bot commented Nov 29, 2022

🦋 Changeset detected

Latest commit: 8c7ea29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@moralisweb3/next Patch
@moralisweb3/api-utils Patch
@moralisweb3/auth Patch
@moralisweb3/codegen Patch
@moralisweb3/evm-api Patch
@moralisweb3/evm-utils Patch
@moralisweb3/parse-server Patch
@moralisweb3/sol-api Patch
@moralisweb3/sol-utils Patch
@moralisweb3/streams Patch
@moralisweb3/test-utils Patch
@moralisweb3/common-auth-utils Patch
@moralisweb3/common-core Patch
@moralisweb3/common-evm-utils Patch
@moralisweb3/common-sol-utils Patch
@moralisweb3/common-streams-utils Patch
@moralisweb3/client-api-utils Patch
@moralisweb3/client-evm-api Patch
@moralisweb3/client-firebase-api-utils Patch
@moralisweb3/client-firebase-auth-utils Patch
@moralisweb3/client-firebase-evm-api Patch
@moralisweb3/client-firebase-evm-auth Patch
@moralisweb3/client-firebase-sol-api Patch
@moralisweb3/client-firebase-sol-auth Patch
@moralisweb3/client-sol-api Patch
moralis Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Y0moo Y0moo added the bug Something isn't working label Nov 29, 2022
Co-authored-by: Erno Wever <erno@moralis.io>
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

Test coverage

Title Lines Statements Branches Functions
api-utils Coverage: 25%
26.34% (49/186) 19.14% (9/47) 22.85% (8/35)
auth Coverage: 90%
92.77% (77/83) 81.81% (18/22) 90% (18/20)
evm-api Coverage: 100%
100% (79/79) 66.66% (6/9) 100% (47/47)
common-evm-utils Coverage: 64%
65% (938/1443) 19.93% (123/617) 35.89% (201/560)
sol-api Coverage: 96%
96.66% (29/30) 66.66% (6/9) 91.66% (11/12)
common-sol-utils Coverage: 74%
73.77% (135/183) 60% (12/20) 65.67% (44/67)
common-streams-utils Coverage: 93%
93.13% (787/845) 85.96% (196/228) 84.14% (276/328)
streams Coverage: 87%
86.71% (398/459) 67.14% (47/70) 84.52% (71/84)

@Y0moo Y0moo merged commit d9acf3a into main Nov 29, 2022
@Y0moo Y0moo deleted the fix/nextjs-rerenders branch November 29, 2022 16:20
@github-actions github-actions bot mentioned this pull request Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants