Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate common-core and umbrella package configs #792

Merged
merged 4 commits into from
Nov 9, 2022

Conversation

FedericoAmura
Copy link
Contributor


name: 'common-core parameters not using all possible options from umbrella'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

This PR solves that when starting the common core package you are offered to pass an apiKey, which is not needed and should not be used on FE

Related issue: #FILL_THIS_OUT

Solution Description

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2022

⚠️ No Changeset found

Latest commit: 081b317

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Test coverage

Title Lines Statements Branches Functions
api-utils Coverage: 56%
56.55% (263/465) 41.5% (44/106) 57.73% (56/97)
auth Coverage: 100%
100% (143/143) 90.9% (20/22) 100% (42/42)
evm-api Coverage: 82%
81.46% (466/572) 16.56% (54/326) 64.3% (191/297)
common-evm-utils Coverage: 63%
63.61% (675/1061) 35.35% (105/297) 31.79% (117/368)
sol-api Coverage: 100%
100% (20/20) 66.66% (4/6) 100% (6/6)
common-sol-utils Coverage: 75%
74.86% (134/179) 63.15% (12/19) 65.67% (44/67)
common-streams-utils Coverage: 95%
95.6% (674/705) 97.93% (190/194) 100% (244/244)
streams Coverage: 82%
82.72% (388/469) 64% (64/100) 73.6% (92/125)

Copy link
Contributor

@sogunshola sogunshola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change

@FedericoAmura FedericoAmura merged commit e14fba8 into beta Nov 9, 2022
@FedericoAmura FedericoAmura deleted the feat/coreConfigValues branch November 9, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants