Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing @moralisweb3/sol-utils dependency to moralis package #609

Merged
merged 4 commits into from
Aug 25, 2022

Conversation

meseta
Copy link
Contributor

@meseta meseta commented Aug 24, 2022


name: 'add missing @moralisweb3/sol-api dependency to core'
about: index.ts imports @moralisweb3/sol-utils in index.ts, but it's not listed as a dependency

Checklist

  • [ x] I am not disclosing a vulnerability.
  • [ x] My code is conform the code style
  • [ x] I have made corresponding changes to the documentation
  • [ x] I have updated Typescript definitions when needed

Issue Description

index.ts imports @moralisweb3/sol-utils in index.ts, but it's not listed as a dependency

Solution Description

add @moralisweb3/sol-utils to dependency

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2022

🦋 Changeset detected

Latest commit: 08364f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
moralis Patch
@moralisweb3/core Patch
@moralisweb3/auth Patch
@moralisweb3/api-utils Patch
@moralisweb3/evm-utils Patch
@moralisweb3/sol-utils Patch
@moralisweb3/evm-api Patch
@moralisweb3/sol-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@b4rtaz b4rtaz changed the title add missing @moralisweb3/sol-utils dependency to core add missing @moralisweb3/sol-utils dependency to moralis package Aug 24, 2022
@b4rtaz b4rtaz changed the title add missing @moralisweb3/sol-utils dependency to moralis package fix: add missing @moralisweb3/sol-utils dependency to moralis package Aug 24, 2022
Copy link
Collaborator

@b4rtaz b4rtaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

Copy link
Collaborator

@b4rtaz b4rtaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier didn't pass.

Checking formatting...
[warn] package.json
[warn] Code style issues found in the above file. Forgot to run Prettier?
error Command failed with exit code 1.

You need to call yarn format in the root of this repository and commit changes.

@ErnoW ErnoW merged commit 30b320a into MoralisWeb3:main Aug 25, 2022
@ErnoW
Copy link
Member

ErnoW commented Aug 25, 2022

Fixed the prettier warning, thanks for the contribution!

@github-actions github-actions bot mentioned this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants