feat(apiUtils): apiUtil package without test #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 386263e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
b4rtaz
requested changes
Jul 18, 2022
|
|
||
| export class ApiConfigSetup { | ||
| public static register(config: Config) { | ||
| config.registerKey(ApiConfig.apiKey); |
There was a problem hiding this comment.
config.registerKey(ApiConfig.apiKey) can be registered in the config only one time. But it's required for evm-api and sol-api modules. So that means, that key cannot be registered in evm-api/sol-api modules double times. Considering this fact that means we need a next module. I suggest to rename apiUtils to api, and add MoralisApi extends ApiModule class to the api package.
@moralisweb3/api <-- module, registers `apiKey` in the config
@moralisweb3/evm-api <-- module, has `@moralisweb3/api` dependency
@moralisweb3/sol-api <-- module, has `@moralisweb3/api` dependency
change package name to register apiKey once
…into feat/apiutils
…into feat/apiutils
b4rtaz
approved these changes
Jul 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 'Pull request'
about: A new pull request
New Pull Request
Checklist
Issue Description
Related issue: #
FILL_THIS_OUTSolution Description