-
Notifications
You must be signed in to change notification settings - Fork 257
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
missing dependencies validator. (#803)
- Loading branch information
Showing
12 changed files
with
533 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| const fs = require('fs'); | ||
| const path = require('path'); | ||
| const ts = require('typescript'); | ||
|
|
||
| const PACKAGE_DIR_PATHS = ['../packages', '../packages/common', '../packages/client']; | ||
|
|
||
| const SKIP_DIRECTORIES = ['lib', 'integration', 'node_modules']; | ||
|
|
||
| function findPackages(dirPath) { | ||
| const result = []; | ||
| fs.readdirSync(dirPath).forEach((fileName) => { | ||
| const filePath = path.join(dirPath, fileName); | ||
| const packagePath = path.join(filePath, 'package.json'); | ||
| if (fs.statSync(filePath).isDirectory() && fs.existsSync(packagePath)) { | ||
| result.push(filePath); | ||
| } | ||
| }); | ||
| return result; | ||
| } | ||
|
|
||
| function findFilesWithExt(rootDirPath, ext, ignoreExt, ignoredDirectoryNames) { | ||
| const result = []; | ||
| function iterate(dirPath) { | ||
| fs.readdirSync(dirPath).forEach((fileName) => { | ||
| const filePath = path.join(dirPath, fileName); | ||
| if (fs.statSync(filePath).isDirectory() && !ignoredDirectoryNames.includes(fileName)) { | ||
| iterate(filePath); | ||
| } else if (fileName.endsWith(ext) && !fileName.endsWith(ignoreExt)) { | ||
| result.push(filePath); | ||
| } | ||
| }); | ||
| } | ||
| iterate(rootDirPath); | ||
| return result; | ||
| } | ||
|
|
||
| function readTsFilesExternalImports(filePaths) { | ||
| const imports = new Set(); | ||
| const program = ts.createProgram(filePaths, {}); | ||
| for (const tsFilePath of filePaths) { | ||
| const sourceFile = program.getSourceFile(tsFilePath); | ||
| for (const imp of sourceFile.imports) { | ||
| const importPath = imp.text; | ||
| if (!importPath.startsWith('../') && !importPath.startsWith('./')) { | ||
| imports.add(importPath); | ||
| } | ||
| } | ||
| } | ||
| return [...imports]; | ||
| } | ||
|
|
||
| function findPackageMissingDependencies(packageDirPath) { | ||
| const packageJsonPath = path.join(packageDirPath, 'package.json'); | ||
| const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8')); | ||
| if (packageJson.private) { | ||
| return []; | ||
| } | ||
| const packageDependencies = Object.keys(packageJson.dependencies || {}); | ||
|
|
||
| const tsFilePaths = findFilesWithExt(packageDirPath, '.ts', '.test.ts', SKIP_DIRECTORIES); | ||
| const imports = readTsFilesExternalImports(tsFilePaths); | ||
|
|
||
| return imports.reduce((result, imp) => { | ||
| if (!packageDependencies.includes(imp)) { | ||
| result.push(imp); | ||
| } | ||
| return result; | ||
| }, []); | ||
| } | ||
|
|
||
| const allPackagePaths = PACKAGE_DIR_PATHS.map((p) => path.join(__dirname, p)) | ||
| .map(findPackages) | ||
| .flat(); | ||
| let exitCode = 0; | ||
|
|
||
| for (const packagePath of allPackagePaths) { | ||
| const packageName = packagePath; | ||
| const missingDependencies = findPackageMissingDependencies(packagePath); | ||
| if (missingDependencies.length > 0) { | ||
| console.log(`❌ Package ${packageName} has missing dependencies:\n* ${missingDependencies.join('\n* ')}\n`); | ||
| exitCode = 1; | ||
| } else { | ||
| console.log(`✅ Package ${packageName} is valid`); | ||
| } | ||
| } | ||
|
|
||
| process.exit(exitCode); |
Oops, something went wrong.
51d7b9dThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test coverage