Merge pull request #825 from MoralisWeb3/fix/find-missing-deps

Fix: findMissingDependencies script

scripts/findMissingDependencies.js

@@ -6,8 +6,6 @@ const PACKAGE_DIR_PATHS = ['packages', 'packages/common', 'packages/client'];
 
 const SKIP_DIRECTORIES = ['lib', 'integration', 'node_modules'];
 
-const IGNORE_DEPENDENCIES = ['parse/node'];
-
 function findPackages(dirPath) {
   const result = [];
   fs.readdirSync(dirPath).forEach((fileName) => {
@@ -51,19 +49,37 @@ function readTsFilesExternalImports(filePaths) {
   return [...imports];
 }
 
+function readImports(tsFilePaths) {
+  return readTsFilesExternalImports(tsFilePaths).map((imp) => {
+    const hasSlash = imp.includes('/');
+    if (!hasSlash) {
+      return imp;
+    }
+    const nameParts = imp.split('/');
+    const isScopePackage = imp.includes('@');
+
+    if (isScopePackage) {
+      return `${nameParts[0]}/${nameParts[1]}`;
+    }
+
+    return nameParts[0];
+  });
+}
+
 function findPackageMissingDependencies(packageDirPath) {
   const packageJsonPath = path.join(packageDirPath, 'package.json');
   const packageJson = JSON.parse(fs.readFileSync(packageJsonPath, 'utf-8'));
   if (packageJson.private) {
     return null;
   }
-  const packageDependencies = Object.keys(packageJson.dependencies || {});
+  const packageDependencies = { ...(packageJson?.dependencies || {}), ...(packageJson?.devDependencies || {}) };
+  const dependenciesList = Object.keys(packageDependencies || {});
 
   const tsFilePaths = findFilesWithExt(packageDirPath, '.ts', '.test.ts', SKIP_DIRECTORIES);
-  const imports = readTsFilesExternalImports(tsFilePaths);
+  const imports = readImports(tsFilePaths);
 
   const missing = imports.reduce((result, imp) => {
-    if (!packageDependencies.includes(imp) && !IGNORE_DEPENDENCIES.includes(imp)) {
+    if (!dependenciesList.includes(imp)) {
       result.push(imp);
     }
     return result;
@@ -75,6 +91,7 @@ const repositoryPath = path.resolve(__dirname, '..');
 const allPackagePaths = PACKAGE_DIR_PATHS.map((p) => path.join(repositoryPath, p))
   .map(findPackages)
   .flat();
+
 let exitCode = 0;
 
 for (const packagePath of allPackagePaths) {