feat: ✨ Upgrade trie-db 0.29.1 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
links234
approved these changes
May 15, 2024
ffarall
approved these changes
May 15, 2024
| @@ -352,7 +352,7 @@ fn commitment_verifier_challenge_key_before_first_key_success() { | |||
| // This is due to some inconsistent behaviour in the iterator, that when you seek to a key | |||
| // that is less than the first key, it will return the first key as the next_back leaf, | |||
| // even if it is not lower than the challenge key. | |||
| assert!(prev_leaf == next_leaf && challenged_key_vec < next_leaf.unwrap().unwrap().0); | |||
| assert!(prev_leaf.is_none() && challenged_key_vec < next_leaf.unwrap().unwrap().0); | |||
There was a problem hiding this comment.
Change doc comment to:
Assert that challenge_key is below next_leaf and that prev_leaf is None.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug with the double ended iteration implemented in
trie-dbwhich broke the behaviour expected fornext_back()to yield eitherNoneor the previous leaf node afterseek(challenge).The fix was merged in paritytech/trie#215 with a minor version upgrade from
trie-db@0.29.0totrie-db@0.29.1. Since it is a minor version, we can apply it to our dependencies without requiringsp-trieto upgrade it's sub dependency ontrie-db.Changes:
trie-dbto0.29.1trie-dbversionprev_leafwhich can beNonenow based on fixed double ended trie iteration behaviourprev_leafto beNoneinstead of being equal tonext_leaf