-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: MSP reject storage requests for existing file keys #224
Merged
snowmead
merged 46 commits into
main
from
feat/msp-reject-storage-requests-for-existing-file-keys
Oct 12, 2024
Merged
feat: MSP reject storage requests for existing file keys #224
snowmead
merged 46 commits into
main
from
feat/msp-reject-storage-requests-for-existing-file-keys
Oct 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added NewStorageRequest handler event for UserSendFileTask. It also modifies the MSP and User tasks to respond process NewStorageRequest events if it is intended for them.
…torage-requests-tasks
…torage-requests-tasks
…torage-requests-tasks
…ctor forest storage handler impls for different storage layers, create forest if bucket does not exist, user retry upload request to msp, batch apply delta to forests msp
…reject-storage-requests-for-existing-file-keys
…storage request, return when reached max upload request retries, renamed mspnet package scripts to fullnet, msp rejecting storage request integration test for duplicate file key
…reject-storage-requests-for-existing-file-keys
…reject-storage-requests-for-existing-file-keys
snowmead
force-pushed
the
feat/msp-reject-storage-requests-for-existing-file-keys
branch
from
October 11, 2024 18:23
ca81591
to
99d248e
Compare
ffarall
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
snowmead
deleted the
feat/msp-reject-storage-requests-for-existing-file-keys
branch
October 12, 2024 00:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test for file key rejection for existing file keys in forest storage.
Fixes
ForestCaching
locking mechanism in RocksDB implementations.