add comment to explain why it's needed

Moonsong-Labs · Jan 4, 2024 · d27b13e · d27b13e
1 parent 435d0cf
commit d27b13e
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pallets/author-inherent/src/lib.rs b/pallets/author-inherent/src/lib.rs
@@ -117,6 +117,9 @@ pub mod pallet {
 			T::DbWeight::get().reads_writes(1, 2)
 		}
 		fn on_finalize(_: BlockNumberFor<T>) {
+			// According to parity, the only wayt to ensure that a mandatory inherent is included
+			// is by checking on block finaliztion that the inherent set a particular storage item:
+			// https://github.com/paritytech/polkadot-sdk/issues/2841#issuecomment-1876040854
 			assert!(
 				InherentIncluded::<T>::get() == true,
 				"Block invalid, missing inherent `kick_off_authorship_validation`"