Skip to content

Conversation

@specture724
Copy link
Collaborator

@specture724 specture724 commented Oct 9, 2025

Resolve #25
Merge _update_per_bucket_p2p with _update_per_bucket. Topology-awared receiver assignment strategy implemented to make full use of bandwidth

@specture724 specture724 self-assigned this Oct 14, 2025
@specture724 specture724 requested a review from Copilot October 14, 2025 08:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes the P2P (peer-to-peer) update logic by merging the _update_per_bucket_p2p function with the existing _update_per_bucket function and implementing a topology-aware receiver assignment strategy to maximize bandwidth utilization.

  • Consolidated P2P and broadcast update logic into a single unified function
  • Added RDMA device topology awareness for optimal receiver assignment
  • Enhanced metadata structures to include RDMA device information
Comments suppressed due to low confidence (1)

checkpoint_engine/ps.py:1

  • This line was removed but self._current_global_parameter_metas is still being used later in the function without proper initialization. This could cause issues if the dictionary is not properly initialized elsewhere.
from __future__ import annotations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

specture724 and others added 6 commits October 14, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Speedup update P2P

3 participants