Mdev v4 only #244
Mdev v4 only #244
Conversation
WalkthroughThe updates simplify and modernize the PlatformIO configuration by removing legacy ESP8266 core versions, streamlining ESP32 environment inheritance, and adjusting flash mode for a specific board. In the BME280 usermod, calls to the String constructor for MQTT publishing now explicitly cast decimal precision arguments to unsigned types for type safety. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (4)
usermods/BME280_v2/usermod_bme280.h (4)
261-261: Duplicate: explicit cast advice
Same as above.
266-266: Duplicate: explicit cast advice
Same as above.
271-271: Duplicate: explicit cast advice
Same as above.
288-288: Duplicate: explicit cast advice
Same as above.
🧹 Nitpick comments (3)
platformio.ini (2)
203-203: Duplicate build_flags_esp32 and build_flags_esp32_V4 definitions
You’ve defined bothbuild_flags_esp32andbuild_flags_esp32_V4with the same${common.build_flags} ${esp32_idf_V4.build_flags}. Consider consolidating or removing the unused one to reduce confusion.
2685-2685: Adjust flash_mode comment to match new mode
You’ve changedboard_build.flash_modefromdouttodioforesp32_pico_4MB_M. Please update the inline comment to(dio = dual i/o; more compatible than qio = quad i/o)and verify this mode works on Pico32 hardware.usermods/BME280_v2/usermod_bme280.h (1)
248-248: Explicit cast ensures correct overload resolution
The(unsigned)cast forces selection of theString(float, unsigned char)constructor. SinceTemperatureDecimalsis already auint8_t, you could usestatic_cast<uint8_t>(TemperatureDecimals)for clarity or omit the cast entirely.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
platformio.ini(4 hunks)usermods/BME280_v2/usermod_bme280.h(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (20)
- GitHub Check: Builds (esp32S3_4MB_PSRAM_M)
- GitHub Check: Builds (esp32_16MB_V4_S)
- GitHub Check: Builds (esp32c3mini_dio_4MB_M)
- GitHub Check: Builds (esp01_1MB_S)
- GitHub Check: Builds (esp8266_4MB_M)
- GitHub Check: Builds (esp8266_2MB_S)
- GitHub Check: Builds (esp32c3dev_4MB_M)
- GitHub Check: Builds (esp32s2_PSRAM_M)
- GitHub Check: Builds (esp32S3_4MB_S)
- GitHub Check: Builds (esp32S3_8MB_M)
- GitHub Check: Builds (esp32_4MB_V4_HUB75_forum)
- GitHub Check: Builds (esp32_4MB_PSRAM_S)
- GitHub Check: Builds (esp32_16MB_M)
- GitHub Check: Builds (esp32_pico_4MB_M)
- GitHub Check: Builds (esp32_16MB_M_eth)
- GitHub Check: Builds (esp32_4MB_XL)
- GitHub Check: Builds (esp32_4MB_M_debug)
- GitHub Check: Builds (esp32_4MB_S)
- GitHub Check: Builds (esp32_4MB_M_eth)
- GitHub Check: Builds (esp32_4MB_M)
🔇 Additional comments (2)
platformio.ini (2)
337-337: Update ESP32 lib_deps to ESP-IDF V4
Changinglib_deps = ${esp32_idf_V4.lib_deps}correctly redirects dependencies to the V4 suite. No further action needed here.
324-327: ESP32 environment now inherits ESP-IDF V4 settings
Switching[esp32]to use${esp32_idf_V4.platform},${esp32_idf_V4.platform_packages}, and${esp32_idf_V4.build_flags}aligns with the PR goal. Ensure that no other environments or scripts still reference the old ESP-IDF v3 settings.#!/bin/bash # Verify no residual espressif32@ entries (v3) remain outside esp32_idf_V4 rg -n "espressif32@" platformio.ini | grep -v "\[esp32_idf_V4"
Update all builds to be using the V4 ESP-IDF, no more V3
Summary by CodeRabbit
Chores
Style