Skip to content

Release 1.2.0: Self-descriptors #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 10, 2024
Merged

Release 1.2.0: Self-descriptors #15

merged 9 commits into from
Sep 10, 2024

Conversation

MooVC
Copy link
Owner

@MooVC MooVC commented Sep 3, 2024

Pull Request

Description

Added

  • FLTFY07 is now raised if the usage of the Descriptor attribute results in the same value that Fluentify would selected by default.

Changed

Checklist

Please ensure the following are true for your PR:

  • I have followed the project's coding style guidelines.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have verified that new and existing unit tests pass locally with my changes.
  • I have updated the documentation (if applicable).
  • I have confirmed that my code is free from warnings and errors.
  • I have reviewed suggestions and determined no actions is required.
  • I have updated the CHANGELOG.md
  • I have performed a self-review of my code.

MooVC added 6 commits August 28, 2024 21:36
- FLTFY07 is now raised if the usage of the `Descriptor` attribute results in the same value that Fluentify would selected by default.

## Changed

- The Descriptor attribute can now direct Fluentify to use the delcared name as the Descriptor without having to repeat the declared name (#9).
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 95.49550% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.72%. Comparing base (f691344) to head (142f9ec).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Fluentify/DescriptorAttributeAnalyzer.cs 90.56% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   96.33%   96.72%   +0.38%     
==========================================
  Files          88       95       +7     
  Lines        1174     1251      +77     
  Branches       95      105      +10     
==========================================
+ Hits         1131     1210      +79     
+ Misses         22       21       -1     
+ Partials       21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MooVC MooVC merged commit 1277eb6 into master Sep 10, 2024
3 of 4 checks passed
@MooVC MooVC deleted the feature/9-pm-descriptor branch September 10, 2024 20:56
@MooVC MooVC linked an issue Sep 10, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for Declared Name to be the Descriptor
1 participant