Update packaging and neo4j version #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcauliffe
reviewed
Jul 7, 2024
Member
mmcauliffe
left a comment
mmcauliffe
left a comment
There was a problem hiding this comment.
This looks great!
It might be worth looking into migrating information in setup.py to a either setup.cfg file like https://github.com/MontrealCorpusTools/Montreal-Forced-Aligner/blob/main/setup.cfg or into the pyproject.toml. At this point, I think the ideal is to have as little information in setup.py, though I don't think there's a way to do the windows-only dependency via configuration files.
Member
|
Hi @mmcauliffe @lxy2304 -- I trust Michael's review on this, so just let me know how to proceed. Does Xiaoyi address the things noted above, then I approve? |
Collaborator
Author
|
@msonderegger Sounds good to me! I am working on the comments Michael suggested and will make a commit with the changes later. |
mmcauliffe
reviewed
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.