fix runner labels generation #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skarzi
commented
Mar 25, 2021
| @@ -30,6 +30,7 @@ | |||
| - name: Check Runner | |||
| assert: | |||
| that: | |||
| - registered_runners.json.runners|json_query('labels[*].name')|flatten|sort == ['Linux', 'self-hosted', 'x86'] | |||
There was a problem hiding this comment.
I wanted to test if only default labels are used by default (no value for runner_labels provided), but I don't know how run this test :(
|
GitHub UI with useless
|
|
Thx for your PR! 🙂 I will look on it bit later. |
|
And thank you for developing a really useful ansible role! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR fixes issue with wrong label -
[]- added for a self-hosted GitHub Actions Runner when usinggithub_actions_runneransible role with defaultrunner_labelsvalue ([]).Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I have tried to test it locally with
molecule, however, it's quite complicated, so please consider it untested locally, and let's rely on CI