Use github_owner in org runner_service #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to create runners for repos which are not owned by the user, but to which the user has access
Fix hide_sensitive_logs variable
Installation idempotence fix
README correction
Add static name for download destination folder
|
Hey @jordemort nice catch, thanks! But could you please change the destination branch to |
|
@jordemort your fix is in release |
|
@MonolithProjects Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file uses
github_owneralmost everywhere but the service name. I found that the service name for an org runner was created using the org name, not the username, which was preventing the playbook from finding the service. This usesgithub_ownerin the service name too. With this change I was able to successfully provision an org runner.