Skip to content

Sync Develop to Master #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 8, 2021
Merged

Sync Develop to Master #117

merged 3 commits into from
Dec 8, 2021

Conversation

MonolithProjects
Copy link
Owner

Description

Original User PR #116
According to issue Custom service names appear to be broken #74, the service name was not fixed by PR #106.

So I had an error on playbook task monolithprojects.github_actions_runner : START and enable Github Actions Runner service:
"Could not find the requested service actions.runner._services.organisation-repo.hostname.service: host"

Indeed, the service name on GHES should be: actions.runner._services.<RUNNER_NAME>.service

Also, I noticed that I can put spaces into my runner_name, but the service name should have spaces replaced by underscores. This affect GHES and Github.com

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Minor change (pipeline, tests, spelling ...)

How Has This Been Tested?

I tested my changes on Ubuntu 20.04, with GitHub runner 2.278.0 and latest (2.235.0), and with runner_org: no, runner_org: yes.

Destination branch

Create a PR into develop branch

@MonolithProjects MonolithProjects merged commit db2c89e into master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants