Sync Develop to Master #117
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original User PR #116
According to issue Custom service names appear to be broken #74, the service name was not fixed by PR #106.
So I had an error on playbook task
monolithprojects.github_actions_runner : START and enable Github Actions Runner service
:"Could not find the requested service actions.runner._services.organisation-repo.hostname.service: host"
Indeed, the service name on GHES should be:
actions.runner._services.<RUNNER_NAME>.service
Also, I noticed that I can put spaces into my runner_name, but the service name should have spaces replaced by underscores. This affect GHES and Github.com
Type of change
How Has This Been Tested?
I tested my changes on Ubuntu 20.04, with GitHub runner 2.278.0 and latest (2.235.0), and with
runner_org: no
,runner_org: yes
.Destination branch
Create a PR into
develop
branch