Skip to content

Conversation

enguerr
Copy link

@enguerr enguerr commented Apr 10, 2020

Hello,
Thanks for your work on this plugin.
I've got to edit this plugin in order to fit my needs.
I've a reverse proxy with Kerberos SSO enabled.
i needed to enable basic auth with 'REMOTE_USER' OR 'PHP_AUTH_USER' with auto-provisionning.
I've read that you planned to add this, and i've just completed the config.

I've temporarly added my url in the project in order to inform my team about updates.
But if you accept my pull request, i will reset the headers in php files to redirect to your project instead of mine.

Tell me if your project page is always alive and if you want to maintain this project with my contributions.

enguerr added 3 commits April 10, 2020 10:37
…ag/1.2.0/) - 2020-04-10

### Changed
- Sso behind nginx proxy
- Auto login with /s/sso_login/LdapAuth
- Button added on login screen to login with AD
- Auto-provisionning from AD special account
@madmath03
Copy link
Member

Hi @enguerr ,

Thanks for sending this PR and the love ❤️

Yes, this project is still alive. We just did not do any enhancement lately since the current features match our needs. We plan to go back on this when we have "free time".

I will review your PR and let you know asap if we're going to accept this 😉

Copy link
Member

@madmath03 madmath03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments.

Also, in general, I'm not sure that it's a good idea for this plugin to use Kerberos as it's a bit too AD centric.
A more generic process which would work on both OpenLDAP and AD is to login against LDAP with "admin" credentials, search for requested user, then verify password.

@madmath03 madmath03 changed the title New features ✨ Kerberos SSO Apr 14, 2020
@madmath03 madmath03 changed the title ✨ Kerberos SSO ✨ Kerberos SSO Apr 14, 2020
@stale
Copy link

stale bot commented Jul 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 12, 2020
@stale stale bot removed the wontfix This will not be worked on label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants