Skip to content

Add Resources and make Donate a button #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Conversation

CartBlanche
Copy link
Collaborator

@CartBlanche CartBlanche commented Feb 5, 2025

Moved Donate button and added link to Resources to the Nav Bar.

Screenshot 2025-02-10 at 12 22 28

@CartBlanche CartBlanche self-assigned this Feb 5, 2025
@CartBlanche CartBlanche changed the title Add resources and make Donate a button Add Resources and make Donate a button Feb 5, 2025
@CartBlanche CartBlanche force-pushed the dominique-AddResources branch from 95c18a0 to d47bffa Compare February 6, 2025 10:27
@SimonDarksideJ
Copy link
Collaborator

Is thie ready to review and merge yet @CartBlanche ?

@CartBlanche
Copy link
Collaborator Author

@SimonDarksideJ No, not yet. It needs 1 more tweak to move the Donate button on closer to the other Nav items (see screennshot). Hopefully later today.

AristurtleDev and others added 3 commits February 10, 2025 16:56
* Inject donate into navbar
DocFX dynamically generates the navbar on the client side through the docfx.js code, it's not something that is statically rendered when the page is built.  In order for the Donate button to be placed to the left of the theme switch button like on the main monogame side, the Donate button needs to be injected after the page loads and then after the navbar is dynamically generated.

* Fix navbar container width so it matches main website
Copy link
Collaborator

@SimonDarksideJ SimonDarksideJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, time to see it in action

@CartBlanche CartBlanche merged commit c78d6fa into main Feb 10, 2025
2 checks passed
@CartBlanche CartBlanche deleted the dominique-AddResources branch February 10, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants