Skip to content

Fix from upstream MojoShader for NOT operator. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tomspilman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix from upstream MojoShader for NOT operator. #3

tomspilman wants to merge 2 commits into from
+10 −4

Conversation

@tomspilman
Copy link
Member

@tomspilman tomspilman commented Jan 23, 2026 •
edited
Loading

tomspilman
tomspilman commented Jan 23, 2026
View reviewed changes
mojoshader/mojoshader.c
const RegisterType regtype = ctx->source_args[0].regtype;
if ((regtype != REG_TYPE_PREDICATE) && (regtype != REG_TYPE_CONSTBOOL))
fail(ctx, "IF src0 must be CONSTBOOL or PREDICATE");
else if (!replicate_swizzle(ctx->source_args[0].swizzle))
Copy link
Member Author

@tomspilman tomspilman Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: This code was removed in the upstream MojoShader repo, but i cannot tell when or why.

But this change makes the test shader in...

MonoGame/MonoGame#8655

Compile.

@tomspilman
Copy link
Member Author

tomspilman commented Jan 23, 2026

Ok this all works and the test shader in...

MonoGame/MonoGame#8655

... compile now.

I built all the stock effects and verified that these MojoShader changes do not break them.

And in theory these changes at worst would cause shaders that didn't compile before, to compile. It should not break any working shaders.

So i feel this is safe, but maybe needs a little testing by users on their own shaders to ensure no issues.

@tomspilman tomspilman mentioned this pull request Jan 23, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mojoshader: NOT only allowed on predicate register

1 participant

@tomspilman