Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drafts] - Player's employment #6855

Open
wants to merge 4 commits into
base: content
Choose a base branch
from

Conversation

lunulae
Copy link
Contributor

@lunulae lunulae commented Dec 30, 2020

This is a beginning draft for some player variables regarding work, I'm also working on an "are you in school" version.
This first iteration contains a lot of menu options, but I tried to keep them as a pretty wide umbrella. I might condense employment and freelance into one option.

I would like to open this for discussion, as I'm not certain if it currently suits what we want for other dialogue options.

Todos;

  • exps
  • locking corresponding goodbyes
  • are these variables good, should others be added/subtracted?
  • if you've already used work goodbye, should the dialogue be different?
  • variant paths (i.e. "you were looking for a job, now you have one")

@multimokia multimokia added awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed discussion treat this issue/pr as a debate/discussion point labels Dec 31, 2020
@lunulae lunulae changed the base branch from master to content January 1, 2021 19:03
)

label monika_player_employment:
if mas_event_mailbox.is_monika_initiated_mode():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just also an FYI to leave this out for now until we get the talk menu awareness stuff merged into upstream MAS, since
a) These aren't necessarily final
b) These don't exist in content right now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take these out in my next draft, no problem. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed discussion treat this issue/pr as a debate/discussion point
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants