Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New topic on studying #6651

Open
wants to merge 10 commits into
base: content
Choose a base branch
from
Open

New topic on studying #6651

wants to merge 10 commits into from

Conversation

Daiozen
Copy link
Contributor

@Daiozen Daiozen commented Nov 6, 2020

Tagging this one as draft while I go throught the rest of the topics to see where the new pm could be useful.

@fromulus I tried to work in your suggestions, but I think adding more subjects really break the flow.
They're probably better left to their own topics imo.

@Daiozen
adding the topic
536b545 
@fromulus I tried to work in your suggestions, but I think adding more subjects really break the flow.
They're probably better left to their own topics imo.
@Daiozen
typo
5e2c742
@Daiozen
Edits as discussed.
52deec9
@Daiozen
edits
ef2f4a2
@Daiozen
edits school farewell
9d196e7
@Daiozen
edits school greeting
936d266
@Daiozen Daiozen marked this pull request as ready for review December 5, 2020 22:52
@Daiozen
Copy link
Contributor Author

Daiozen commented Dec 5, 2020

Edits done. Ready for review.

@multimokia multimokia self-requested a review December 21, 2020 18:49
@multimokia multimokia added this to the Next Release milestone Dec 21, 2020
@multimokia multimokia added awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested labels Dec 21, 2020
@multimokia
Copy link
Member

Adding don't merge as this is pending a semi-rewrite in which it's split up into two topics.

  1. Acting as a sort of check-in for school, how you're doing if you're struggling etc. and how to potentially cope with parts of school
  2. A separate pm var topic regarding whether or not you enjoy(ed) school/if you had trouble etc.

This is also awaiting a topic regarding whether or not you're in school still.

@multimokia multimokia removed their request for review January 4, 2021 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting code review someone needs to check for syntax/logic/indentation errors awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested DONT MERGE srs rewrite
Projects
None yet
Milestone
Maybe this rel
Development

Successfully merging this pull request may close these issues.
2 participants
@Daiozen @multimokia