Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hero compliment #3790

Merged
merged 5 commits into from
Feb 27, 2019
Merged

Hero compliment #3790

merged 5 commits into from
Feb 27, 2019

Conversation

Rai99
Copy link
Contributor

@Rai99 Rai99 commented Feb 18, 2019

Issue: #3637

@multimokia multimokia added awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Feb 18, 2019
@jmwall24 jmwall24 added the needs sprites we need to add missing sprite codes label Feb 18, 2019
jmwall24
jmwall24 requested changes Feb 27, 2019
View reviewed changes
Monika After Story/game/script-compliments.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-compliments.rpy Outdated Show resolved Hide resolved
Monika After Story/game/script-compliments.rpy Show resolved Hide resolved
@jmwall24 jmwall24 added the awaiting changes the pull request creator needs to make some changes label Feb 27, 2019
jmwall24 and others added 2 commits February 26, 2019 20:40
@jmwall24 @Rai99
Applied suggestions from code review
d020244 
Co-Authored-By: Rai99 <38822045+Rai99@users.noreply.github.com>
@jmwall24
adds 2rkbfsdlb
b257a8f
@jmwall24 jmwall24 removed awaiting changes the pull request creator needs to make some changes awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested needs sprites we need to add missing sprite codes labels Feb 27, 2019
@ThePotatoGuy ThePotatoGuy removed the awaiting code review someone needs to check for syntax/logic/indentation errors label Feb 27, 2019
@ThePotatoGuy ThePotatoGuy merged commit f7bb0f8 into Monika-After-Story:content Feb 27, 2019
@Rai99 Rai99 deleted the Hero-Compliment branch March 31, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThePotatoGuy ThePotatoGuy ThePotatoGuy approved these changes

@jmwall24 jmwall24 jmwall24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rai99 @ThePotatoGuy @jmwall24 @multimokia