-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fixed Document.reload #1052
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed Document.reload #1052
Conversation
|
|
|
PR for #1050 |
|
Good job @Catstyle ! Let me just think if this could have counter-effects on non-fields attribute for non-dynamic documents. If not, it looks good to merge to me |
|
Thank the gods, this is something that I actually frequently ran into, but never had the time to track down. EmbeddedDocument support seems to have gotten quite borked at some point in the recent past. I'll have to check if this fixes the "embedded document has no field '_id'" errors I've been seeing. |
|
|
|
rebased |
|
passed, it wasn't because of you ;) |
|
Merged |
|
@thedrow I werged this PR (see a6a1021, ba0934e and 7580383) However, the PR was in conflict so I had to merge it by hand instead of use github's automerging. I rewrote commit 6a9f27e (the one in conflict) into 7580383. I guess it's the reason github didn't realised the merge has been done. I can revert my changes if you see a better way of doing this 👍 |
use obj._data instead of self._fields_ordered since DynamicDocument missing some attributes