Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Standard Linting #2

Merged
merged 73 commits into from
Aug 20, 2024
Merged

Move to Standard Linting #2

merged 73 commits into from
Aug 20, 2024

Conversation

cattekin
Copy link

@cattekin cattekin commented Aug 19, 2024 •
edited
Loading

Add standard gems and fix styling issues.
Add todo for changes that break specs
Fix minitest deprecations

@cattekin
Add standard linting
e56a8cf
@cattekin
Fix hash syntax
6344baf
@cattekin
Standardise Layout
46b4a97 
- Remove empty lines
- Remove trailing white space
- Add spacing around access modifiers
- Add spacing around blocks and definitions
- Ensure files end with a new line
- Standardise spaces around commas and operators
- Standardise indentation
@cattekin
Standardise on double quotes
63384e2
@cattekin
Use attr_reader over attr
5974325
@cattekin
Update precent delimiters
aef51a3
@cattekin
Remove redundent then calls
90b859b
@cattekin
Remove redundent parens
102d432
@cattekin
Update todo
324f8bf
@cattekin
Don't use semicolons at the end of lines
da7b83a
@cattekin
Don't use colons for method calls
351147c
@cattekin
Standardise trailing commas in hashs
4c639f6
@cattekin
Use memoisation over self assignment
0561f4f
@cattekin
Remove redundent self calls
bfda855
@cattekin
Remove redundent returns
3909353
@cattekin
Remove redundant string coercion
183b004
@cattekin
Standardise string literal interpolation
9d2f1fa
@cattekin
Fix command literal
bac87c4
@cattekin
Standardise class checks
9d785a4
@cattekin
Standardise terneries
d40db56
@cattekin
Remove legacy begin blocks
5f8d5f8
@cattekin
Standardise multi line if statements
5c20579
@cattekin
Clean up nested calls
8fe63c8
@cattekin
Standardise class comparisons
621ca09
@cattekin
Use alias_method over alias
c926909
@cattekin
Clean up code with safe operator
a53605f
@cattekin
Standardise concatenation
0bc3019
@cattekin
Remove space before parens
fa5eacd
@cattekin
Standardise conditional assignments
c3eac80
@cattekin
Use .nil? instead of == for comparisons
f8ad67d
@cattekin
Replace deprecated monkey patch with wrapped calls
3893000
@cattekin
Prefer ! over not
afb5db7
@cattekin
Use each over for loops
2973c5b
@cattekin
Use file.write over open
b399c14
@cattekin
Use until over negated while
7326c6e
@cattekin
Use modern proc format
d6133e0
@cattekin
Fix lack of global source in gemfile
9feeb53
@cattekin
Use standardised or queries
a89025b
@cattekin
Remove redundent ternery
4619df0
@cattekin
Remove legacy do blocks from while loops
3353236
@cattekin
Remvoe explicit Exeption from rescue
b7a45ba
@cattekin
Don't define test classes in blocks
b2ee64a
@cattekin
Use each_with_object over inject
19a96ed
@cattekin
Clean up regexps
3fe405a
@cattekin
Remove redudant conditionals
1b090f3
@cattekin
Remove redundant assignments
b2d01fa
@cattekin
Move indentical parts out of conditional assignment
ce0d441
@cattekin
Remove redundent assignments
d1615b6
@cattekin
Remove redundant merge calls
a93e3a4
@cattekin
Use match? calls for regexp
079476a
@cattekin
Prefer multiline rescue blocks
7139278
@cattekin
Use reverse_each
a007a8f
@cattekin
Use count over select.size
4302b0e
@cattekin
Use snake_case for ruby variable names
9d1a5a2
@cattekin
Use screaming snake case for constant names
257f363
@cattekin
Update method calls to match ruby standard for unused calls
8ea8bf2
@cattekin
Wrap conditional assignments in parens
3dcdad8
@cattekin cattekin merged commit 73ca6c8 into main Aug 20, 2024
2 checks passed
@cattekin cattekin deleted the standard branch August 20, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cattekin