Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Contributions By Organization" #168

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Add "Contributions By Organization" #168

merged 2 commits into from
Oct 21, 2020

Conversation

Lnaden
Copy link
Collaborator

@Lnaden Lnaden commented Oct 21, 2020

Description

Adds a contribution by organization page which handily lists all
the contributions from a single organization, auto-populated from the
data/organizations directory and based on the
creator/organization/lab/institute fields of every model and simulation.

Each Org listed this way has the ability to grab the URL to that master
list on the page itself.

Page can be found by the top level navigation under the
"Contribution -> Contributions by Organization" header.

Also made a small change to the entry anchors so URL's can be a bit shorter.
Old URL's will continue to work.

Added the ability have alternate names and spellings for organizations
which are automatically compared against for who contributed what data.
This is all case and whitespace insensitive.

Fixes #158

cc @jchodera

Status

  • YAML file for each piece of data
  • Ready to go

Adds a contribution by organization page which handily lists all
the contributions from a single organization, auto-populated from the
`data/organizations` directory and based on the
creator/organization/lab/institute fields of every `model` and `simulation.`

Each Org listed this way has the ability to grab the URL to that master
list on the page itself.

Page can be found by the top level navigation under the
"Contribution -> Contributions by Organization" header.

Also made a small change to the entry anchors so URL's can be a bit shorter.
Old URL's will continue to work.

Added the ability have alternate names and spellings for organizations
which are automatically compared against for who contributed what data.
This is all case and whitespace insensitive.
@Lnaden Lnaden requested review from anabiman and sjayellis October 21, 2020 17:07
Copy link
Collaborator

@sjayellis sjayellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the page looks good. There is something weird with the bounding boxes on the links that I cannot determine the source. When hovering directly over a link, it correctly highlights the link. When the mouse is not directly over a link, it seems to highlight a link a few lines down. Clicking in this state will take you to the highlighted link.

Screenshot attached:
Capture

@Lnaden
Copy link
Collaborator Author

Lnaden commented Oct 21, 2020

I see what you mean, I think its because I have an <h5> wrapped in a <a> so the bounding boxes are odd. Let me try something.

@sjayellis
Copy link
Collaborator

sjayellis commented Oct 21, 2020

I think you can move the <h5> around the whole thing. For the simulations and model entries when you reference the partial. (within the single.html for contributions by organizations.)
e.g.

<h5 align="left">
    <a href='{{ print $.Site.BaseURL "/simulations/#" $entry_name }}'>
    {{ .title }} 
    {{ partial "general-marker" . }}
</h5>

@sjayellis
Copy link
Collaborator

That did it. 👍

@Lnaden Lnaden merged commit 51409cc into master Oct 21, 2020
@Lnaden Lnaden deleted the orgpages branch October 21, 2020 18:01
@Lnaden
Copy link
Collaborator Author

Lnaden commented Oct 21, 2020

That would have worked, but I think we didnt even need a <hX> here, wrapping it in a <p> seems to have worked well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow view of data generated by a given organization
2 participants