Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds prompt for package name #182

Closed
wants to merge 1 commit into from
Closed

Conversation

janash
Copy link
Member

@janash janash commented Nov 10, 2023

This PR adds a prompt for package_name, separate from repo_name. This would address issues like #82, where the error was occurring because the Python package name and the repo name were the same by default. In reality, it's totally realistic to have a repo name like project-name and a package name project_name (or something similar). The CookieCutter currently does not allow having the repo name (outer folder) and package name (inner source directory) be different.

Also addresses #154

I think I've changed most of the necessary files, but would appreciate thoughts/review 👀

@janash
Copy link
Member Author

janash commented Nov 10, 2023

If we wanted to do this in a less aggressive but more clear way, we could also change the prompt from asking what the repo name is to asking the package name. Then it would be more clear that what is specified needs to be a valid Python package name. The repo name could be inferred based on the package name.

@janash janash closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant