Fixing incoming type errors from ts 5.1.3#130
Open
Tommy-Malone-ZOS wants to merge 3 commits intoMojang:mainfrom
Open
Fixing incoming type errors from ts 5.1.3#130Tommy-Malone-ZOS wants to merge 3 commits intoMojang:mainfrom
Tommy-Malone-ZOS wants to merge 3 commits intoMojang:mainfrom
Conversation
…pes looks to have changed. Previously the types of a useFacetMap for example would look like so: After 5.1.3 the types look like so: The selector arguments are infered as the union of the types of all passed in Facets, rather than each arguments type corresponding to their Facet's inner type. This change fixes that issue by explicitly making the array type we were previously extending into a tuple type. This allows TS to correctly infer the arguments' types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating to TS 5.1.3 the behavior of type inference of array types looks to have changed. Previously the types of a useFacetMap for example would look like so:
useFacetMap((a: number, b: string, c: boolean)=>{...},[...],[A: Facet<number>, B: Facet<string>, C: Facet<boolean])After 5.1.3 the types look like so:useFacetMap((a: number | string | boolean, b: number |string | boolean, c: number | string | boolean)=>{...},[...],[A: Facet<number>, B: Facet<string>, C: Facet<boolean>])The selector arguments are infered as the union of the types of all passed in Facets, rather than each arguments type corresponding to their Facet's inner type. This change fixes that issue by explicitly making the array type we were previously extending into a tuple type. This allows TS to correctly infer the arguments' types.