Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #9

Merged
merged 4 commits into from
Sep 26, 2018
Merged

Update README.md #9

merged 4 commits into from
Sep 26, 2018

Conversation

TheIntelloBox
Copy link
Contributor

No description provided.

Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe whilst you're at it you can change " Contributions are suspended until we have a process in place to handle them." to "Contributions are welcome!" 🤔

I kinda forgot ;)

@TheIntelloBox
Copy link
Contributor Author

Done ! :D

@jamierocks
Copy link

Since you're on it - s/new CommandDispatcher(/new Command dispatcher<>(

@Earthcomputer
Copy link
Contributor

And since we're being really picky: When a command is actually ran -> When a command is actually run
:P

@Dinnerbone
Copy link
Contributor

And all of those in the same commit/PR, please? :D

@TheIntelloBox
Copy link
Contributor Author

I don't know how to do that, I'm not a master of code like you. :D

@Earthcomputer
Copy link
Contributor

Just add more commits to your patch-1 branch they will automatically show up here.

@TheIntelloBox
Copy link
Contributor Author

@jamierocks What must I change ?

@Earthcomputer
Copy link
Contributor

This line

CommandDispatcher<CommandSourceStack> dispatcher = new CommandDispatcher();

Should read

CommandDispatcher<CommandSourceStack> dispatcher = new CommandDispatcher<>();

@Dinnerbone Dinnerbone mentioned this pull request Sep 26, 2018
Copy link
Contributor

@Dinnerbone Dinnerbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll squash all these into the same commit. Thank you for your contribution! <3

@TheIntelloBox
Copy link
Contributor Author

No problem sir ! :D

@Dinnerbone Dinnerbone merged commit 6a15305 into Mojang:master Sep 26, 2018
A248 pushed a commit to SolarMC-Dev/brigadier that referenced this pull request Jun 18, 2021
Ensure that the CompletableFuture returned by getCompletionSuggestion…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants