Skip to content

Commit

Permalink
Rename properties per suggestion
Browse files Browse the repository at this point in the history
  • Loading branch information
Mohit-Chakraborty committed Feb 2, 2021
1 parent 34a7066 commit 6b41356
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ public SearchIndexingBufferedSenderOptions() { }
public int? InitialBatchActionCount { get { throw null; } set { } }
public System.Func<T, string> KeyFieldAccessor { get { throw null; } set { } }
public int MaxRetriesPerIndexAction { get { throw null; } set { } }
public System.TimeSpan MaxThrottlingRetryDelay { get { throw null; } set { } }
public System.TimeSpan ThrottlingRetryDelay { get { throw null; } set { } }
public System.TimeSpan MaxThrottlingDelay { get { throw null; } set { } }
public System.TimeSpan ThrottlingDelay { get { throw null; } set { } }
}
public partial class SearchIndexingBufferedSender<T> : System.IAsyncDisposable, System.IDisposable
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,8 @@ public SearchIndexingBufferedSender(
options.InitialBatchActionCount,
options.BatchPayloadSize,
options.MaxRetriesPerIndexAction,
options.ThrottlingRetryDelay,
options.MaxThrottlingRetryDelay,
options.ThrottlingDelay,
options.MaxThrottlingDelay,
options.FlushCancellationToken);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public class SearchIndexingBufferedSenderOptions<T>
/// is used to add delay between additional batch submissions when our
/// requests are being throttled by the service.
/// </summary>
public TimeSpan ThrottlingRetryDelay { get; set; } = TimeSpan.FromSeconds(0.8);
public TimeSpan ThrottlingDelay { get; set; } = TimeSpan.FromSeconds(0.8);

/// <summary>
/// The maximum permissible delay between retry attempts. Note that
Expand All @@ -82,7 +82,7 @@ public class SearchIndexingBufferedSenderOptions<T>
/// property is used to add delay between additional batch
/// submissions when our requests are being throttled by the service.
/// </summary>
public TimeSpan MaxThrottlingRetryDelay { get; set; } = TimeSpan.FromMinutes(1);
public TimeSpan MaxThrottlingDelay { get; set; } = TimeSpan.FromMinutes(1);

/// <summary>
/// Gets or sets a function that can be used to access the index key
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,7 @@ public async Task Behavior_MaxRetries()
new SearchIndexingBufferedSenderOptions<SimpleDocument>()
{
MaxRetriesPerIndexAction = 5,
MaxThrottlingRetryDelay = TimeSpan.FromSeconds(1)
MaxThrottlingDelay = TimeSpan.FromSeconds(1)
});

// Keep 503ing to count the retries
Expand Down Expand Up @@ -1134,7 +1134,7 @@ public async Task Behavior_RetryDelay()
new SearchIndexingBufferedSenderOptions<SimpleDocument>()
{
MaxRetriesPerIndexAction = 1,
ThrottlingRetryDelay = TimeSpan.FromSeconds(3)
ThrottlingDelay = TimeSpan.FromSeconds(3)
});

// Keep 503ing to trigger delays
Expand Down Expand Up @@ -1166,7 +1166,7 @@ public async Task Behavior_MaxRetryDelay()
new SearchIndexingBufferedSenderOptions<SimpleDocument>()
{
MaxRetriesPerIndexAction = 10,
MaxThrottlingRetryDelay = TimeSpan.FromSeconds(1)
MaxThrottlingDelay = TimeSpan.FromSeconds(1)
});

// Keep 503ing to trigger delays
Expand Down

0 comments on commit 6b41356

Please sign in to comment.