Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#185426444 Readme headline normalization, clarification, and expansion of docs #6

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

bakennedy
Copy link
Contributor

@bakennedy bakennedy commented Jun 28, 2023

Removed some redundant documentation

Small fixes and clarification

Expanded usage and configuration section and included relevant Envoy doc links

Removed some redundant documentation

Small fixes and clarification
@bakennedy bakennedy merged commit 6050f03 into master Jun 28, 2023
@@ -75,7 +75,7 @@ clusters:
transport_socket:
name: envoy.transport_sockets.tls
typed_config:
"@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext
"@type": type.googleapis.com/envoy.extensions.transport_sockets.tls.v3.UpstreamTlsContext"
Copy link

@praves77 praves77 Jun 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bakennedy I'm seeing extra " above.

@praves77 praves77 deleted the bk-readme branch June 28, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants