Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#185492729 : Istio support and example cluster configuration #4

Merged
merged 20 commits into from
Jul 10, 2023
Merged

#185492729 : Istio support and example cluster configuration #4

merged 20 commits into from
Jul 10, 2023

Conversation

bakennedy
Copy link
Contributor

@bakennedy bakennedy commented Jun 28, 2023 •
edited
Loading

A minikube reference deployment of istio with ingress gateway configuration using the plugin and routing traffic to the echo service. This loads the plugin from dockerhub

@praves77 praves77 changed the title Istio support and example configuration [WIP] Istio support and example configuration Jun 28, 2023
@bakennedy
Script building and push of test images to private repo
9055dae 
add k8s resources for istio configuration

script istio install and configuration
@bakennedy
debug utility scripts
9b50f9f
@bakennedy
TLS upstream testing gateway, vservice, and routes
54e28bd
@bakennedy
Update script locations, names
07dcdb3
@bakennedy
Explicit subset identification in istio, splt https and http gateways…
6e2d5e7 
…, muli-gateway ingest for in-cluster service, split virtualservice for moesif upstream into one per gateway with explicit TLS config

do not use passthrough TLS in this type of upstream communication

add test route to moesif upstream to confirm access and TLS settings
@bakennedy
Let request scheme be specified by the istio upstream cluster, explic…
f271077 
…it timeout config in millis
@bakennedy
More clear error callback logs
171c6e7
@bakennedy
Sync readme with config
e8942c3
@bakennedy
k8s resource fixes and minimizing for release example
320c4ce
@bakennedy
WASM Hub push script but retaining docker image in example since weba…
7b05a22 
…ssemblyhub.io's TLS cert is currently expired
@bakennedy
Clean up k8s resources and simplify for release example
c8280fa
@bakennedy
Set example file paths and names and use new debug flag for examples
1ee2987
@bakennedy
Copy link
Contributor Author

@dgilling I figured out what's wrong with my attempts to push to our production company dockerhub account. It won't auto-create the repo, and I don't have permission to do it manually.

docker.io/moesif/moesif-envoy-wasm-plugin is the image name in the example wasm, but it's a little redundant. Can you create either a moesif/moesif-envoy-wasm-plugin repo or moesif/envoy-wasm-plugin ?

@bakennedy
Copy link
Contributor Author

bakennedy commented Jul 8, 2023 •
edited
Loading

Additionally there are some utility scripts in this repo which aren't required for users of our istio example or the plugin. Where else should I put them or just release them with this?

Feedback on the other PR is addressed and included in this one

@bakennedy bakennedy changed the title [WIP] Istio support and example configuration Istio support and example cluster configuration Jul 8, 2023
@praves77 praves77 changed the title Istio support and example cluster configuration #185492729 : Istio support and example cluster configuration Jul 8, 2023
@praves77
Copy link

praves77 commented Jul 9, 2023

Thanks @bakennedy let's use Squash and merge button to merge - it's a public repo - we can use consolidated/squashed commit per feature/bugs.

@bakennedy bakennedy merged commit 84d0ff5 into master Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@praves77 praves77 praves77 approved these changes

@dgilling dgilling Awaiting requested review from dgilling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bakennedy @praves77 @dgilling