fix: update type definitions and improve user data extraction from Cognito #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the user data extraction logic from Cognito by switching from signInDetails.loginId to attributes.email and enhancing type definitions. The changes include updating the AuthProvider and useGetCurrentUser implementations, adding a new SignInDetails type in the user model, and updating tests to reflect these changes.
Reviewed Changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/common/providers/AuthProvider.tsx | Update email extraction from signInDetails.loginId to attributes.email in userData |
| frontend/src/common/models/user.ts | Add SignInDetails type definition for capturing Cognito login details |
| frontend/src/common/hooks/tests/useAuthOperations.test.ts | Update test mocks to use AWS SDK proper command output types |
| frontend/src/common/api/useGetCurrentUser.ts | Update email extraction to use cognitoUser.attributes.email |
Files not reviewed (3)
- frontend/package-lock.json: Language not supported
- frontend/package.json: Language not supported
- frontend/tsconfig.json: Language not supported
GuidoBR
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: update type definitions and improve user data extraction from Cognito