This repository was archived by the owner on Jul 13, 2020. It is now read-only.
Fix confusing error when XHR statusText is blank #421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the existing `Error(xhr.statusText + ': ' + url || 'XHR error')` implementation, the LHS of the OR is always truthy, so XHR failures with no statusText yield error messages like `: google.com`. This edit changes that to a slightly-less-cryptic `XHR error: status 0 "": http://google.com` (which yields useful results in a web search), or if there is a statusText, `XHR error: status 403 "Forbidden": http://mydomain.com/page`. (Feel free to just change it directly in the codebase instead of merging if you prefer different formatting, etc.)
|
Sure, thanks. |
guybedford
added a commit
that referenced
this pull request
Aug 2, 2015
Fix confusing error when XHR statusText is blank
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the existing
Error(xhr.statusText + ': ' + url || 'XHR error')implementation, XHR failures with no statusText yield error messages like: google.comsince the LHS of the||is always truthy. This edit changes that to a slightly-less-crypticXHR error: status 0 "": http://google.com(which yields useful results in a web search), or if there is a statusText,XHR error: status 403 "Forbidden": http://mydomain.com/page.(Feel free to just change it directly in the codebase instead of merging if you prefer different formatting, etc.)