This repository was archived by the owner on Jul 13, 2020. It is now read-only.
Use API functions based on availability #228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also support pre-transpiled modules - check if the source starts with System.register, if yes, do not transpile. |
| @@ -5,7 +5,7 @@ function __eval(__source, __global, load) { | |||
| // Hijack System.register to set declare function | |||
| var __curRegister = System.register; | |||
| System.register = function(name, deps, declare) { | |||
| if (typeof name != 'string') { | |||
| if (typeof name != 'string' && typeof name != 'void') { | |||
There was a problem hiding this comment.
What is outputting a void in the System.register name? That should never happen and if it does that is the wrong output mode in Traceur (this sounds like the Traceur register output).
There was a problem hiding this comment.
Hm, that is a good question. You're right, name should never be void, that would not make sense.
Maybe just assert that it is not void?
|
The environment changes all look pretty good, but would be good to separate this from the commented points. |
guybedford
added a commit
that referenced
this pull request
Oct 20, 2014
|
Thanks, I've merged the relevant parts in now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm using es6-module-loader in a custom javascript environment and made these changes to avoid errors.
I have a window object, but do not have a document.getElementsByTagName, I have an XMLHttpRequest but no require.