Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #147

Merged
merged 6 commits into from
Aug 18, 2023
Merged

fixes #147

merged 6 commits into from
Aug 18, 2023

Conversation

ljleb
Copy link
Contributor

@ljleb ljleb commented Aug 18, 2023

  • correctly load workflows from png info
  • use global_state and patch RETURN_TYPES before each workflow for more reliable type checking
  • fix webui ModelPatcher proxy for newer version of comfyui

@ljleb
Copy link
Contributor Author

ljleb commented Aug 18, 2023

PNG info is actually broken with some larger workflows. I'll look into it, but I'm not sure we can do something about it. For example, this workflow (it's in the metadata of the image):

workflow

52944-425230810-1girl

@ljleb
Copy link
Contributor Author

ljleb commented Aug 18, 2023

Found a fix. The webui needs to fix their png info parsing with this regex instead:

\s*([\w ]+):\s*("(?:\\.|[^\\"])+"|[^,]*)(?:,|$)

https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/68f336bd994bed5442ad95bad6b6ad5564a5409a/modules/generation_parameters_copypaste.py#L12

We can patch this line from the extension for the time being.

@ljleb ljleb requested a review from PladsElsker August 18, 2023 15:59
Copy link
Contributor

@PladsElsker PladsElsker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ljleb ljleb merged commit a332cfa into main Aug 18, 2023
@ljleb ljleb deleted the fixes branch August 18, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants