Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illegal data value update checks should not be done in other validation checks #96

Closed
seidewitz opened this issue Oct 8, 2020 · 1 comment
Closed

Illegal data value update checks should not be done in other validation checks #96

seidewitz opened this issue Oct 8, 2020 · 1 comment
Assignees
@seidewitz
Labels
bug

Comments

@seidewitz
Copy link
Contributor

seidewitz commented Oct 8, 2020 •
edited
Loading

The constraint checking methods NameLeftHandSideImpl.nameLeftHandSideTargetAssignment and FeatureLeftHandSideImpl.featureLeftHandSideFeatureExpression include additional checks (over what is called for in the Alf 1.1 specification) that, if the left-hand side is for a feature whose target type is a data type, then the LHS is a legal data value update. However, this is confusing, because the error messages are for different errors. In particular, featureLeftHandSideFeatureExpression is reported as "Target expression must have a multiplicity upper bound of 1", which doesn't make any sense if the real problem is an illegal data value update.
@seidewitz seidewitz added the bug label Oct 8, 2020
@seidewitz seidewitz self-assigned this Oct 8, 2020
seidewitz added a commit that referenced this issue Oct 22, 2020
@seidewitz
Issue #96 Added leftHandSideDataValueUpdateLegality constraint check.
f886999 
- Also disabled assignmentDataValueUpdateLegality, since it is now
redundant.
seidewitz added a commit that referenced this issue Oct 23, 2020
@seidewitz
Issue #96 - Fixed local name output argument problem.
8fbe39a
@seidewitz
Copy link
Contributor Author

Fixed in v1.1.0j.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seidewitz seidewitz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seidewitz