Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExternalElementReferenceImpl.hasReceptionFor can throw a NullPointerException #71

Closed
seidewitz opened this issue Mar 1, 2019 · 2 comments
Closed

ExternalElementReferenceImpl.hasReceptionFor can throw a NullPointerException #71

seidewitz opened this issue Mar 1, 2019 · 2 comments
Assignees
@seidewitz
Labels
bug

Comments

@seidewitz
Copy link
Contributor

seidewitz commented Mar 1, 2019 •
edited
Loading

The test ((Reception)member).getSignal().equals(umlSignal) in ExternalElementReferenceImpl.hasReceptionFor will through a NullPointException if getSignal returns null. Any reception is required by the UML abstract syntax to have a reference to a signal, but some tools may allow this to be null in partial or ill-formed models. The code should be robust against such cases and not through an exception.
@seidewitz seidewitz added the bug label Mar 1, 2019
@seidewitz seidewitz self-assigned this Mar 1, 2019
@seidewitz
Copy link
Contributor Author

seidewitz commented Mar 1, 2019 •
edited
Loading

There is also a possible NPE in ExternalNamespaceImpl.getNewReference if the reference parameter is null.

seidewitz added a commit that referenced this issue Mar 1, 2019
@seidewitz
Issue #71 - Added checks to avoid possible null pointer exceptions.
ff489e3
@seidewitz
Copy link
Contributor Author

Resolved in v1.1.0f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seidewitz seidewitz

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@seidewitz