Skip to content
This repository was archived by the owner on Oct 5, 2025. It is now read-only.

Feature/add eslint and cleanup deps#67

Open
he-james wants to merge 5 commits intostagingfrom
feature/add-eslint-and-cleanup-deps
Open

Feature/add eslint and cleanup deps#67
he-james wants to merge 5 commits intostagingfrom
feature/add-eslint-and-cleanup-deps

Conversation

@he-james
Copy link
Contributor

@he-james he-james commented Nov 24, 2021

Still doesn't do much for cleanliness and best practices. That will be achieved in my next PR.

Reviewers, please be mindful that I literally died to make this. I am now a corpse. If it can be fixed in less than 10 minutes, I will do it, otherwise, I am making the executive decision that each review comment is a "Should" instead of a "Must". I'll be glad to make the changes needed after this is merged in my next branch, as to go this long with out this branch going up is to cause pain to my brain.

Most notable changes:

  • Literally all the syntax
  • Project structure vaguely reflects conventions either I have seen or I have read about in this process. I think most similar to https://wityan.medium.com/next-js-project-structure-1531610bed71
  • Storybook was removed. - @FB-Reda, this was your suggestion, and I actually quite like Storybook - the reason for its addition to the gitignore for now is so that I can take the time needed to standardize it.
  • NextJS was upgraded to Next 12
  • _document.tsx includes font links per NextJS docs on font optimization
  • For now, if this causes trouble with y'all's local dev workflow, either (1) do something locally, (2) checkout an older commit, or (3) do nothing and deal with it for the time being.
  • Usage of compilerOptions.baseUrl and compilerOptions.paths in the tsconfig.json - this is a very essential add, since it cleans up imports rather substantially. Maintainers are welcome to add paths whenever convenient and reasonable.
  • Addition of .husky/ directory and husky pre-commit lint-check - This fixes lint wherever it can, and prevents commits that require manual de-linting. You may find this annoying, but I find lint annoying.
  • A somewhat strict refactor of js -> ts/tsx file extension changes and their code. While using typescript is not required still, I've did this refactor in the middle of the night while I was trying to figure out many type-related errors. I am fairly certain it is still possible to write untyped JS in this repo, but I will say that it will be somewhat more difficult. That being said, feel free to give development a shot - there will be some initial learning curve and frustration, but the benefit of fairly decent typing is that most IDEs will support retrieval of type documentation. This means that writing out props and other type/class attributes has never been more convenient.

Anyway, feel free to explore. I'd recommend checking this out in your own environments and giving it a look-see. This is a pure refactor to add ESLint to our repo and passed the pre-commit check, but obviously cosmetic and readability improvements are highly encouraged.

sdmungov and others added 5 commits August 24, 2021 22:01
* Dev/2 vercel sponsorship (#20) (#25)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2b vercel sponsorship (#31)

* Dev/2 vercel sponsorship (#20) (#21)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2 vercel sponsorship (#20) (#25) (#26)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Update readme

* Update readme

* Update readme

* Release/2021/sprint 1 (#39)

* Dev/2 vercel sponsorship (#20)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2 vercel sponsorship (#20) (#21)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* created the jumbotron component for the landing of the home page and put it in a components folder and imported it into pages/index, set up fonts and colors files and some early global styles but those will be changed over to styled components based off a decision after this code was written (#22)

* installed and set up some basic styled-components, converted parts of jumbotron component and main page ot use some styled components (#24)

* Dev/2 vercel sponsorship (#20) (#25) (#26)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/1 jh deployment rebase (#27)

* Dev/2 vercel sponsorship (#20) (#25) (#26)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* created the jumbotron component for the landing of the home page and put it in a components folder and imported it into pages/index, set up fonts and colors files and some early global styles but those will be changed over to styled components based off a decision after this code was written (#22)

* installed and set up some basic styled-components, converted parts of jumbotron component and main page ot use some styled components (#24)

* Use utm params for vercel redirects

* Readme changes

Co-authored-by: sdmungov <55511406+sdmungov@users.noreply.github.com>

* #18 Initialize New Footer Component
* Add FontAwesome
* Add new footer and associated storybook/styles
* Improved storybook setup

* Dev/2b vercel sponsorship (#30)

* Dev/2 vercel sponsorship (#20) (#21)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2 vercel sponsorship (#20) (#25)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Update readme

* Update readme

* Update readme

* Dev/2b vercel sponsorship (#29)

* Dev/2 vercel sponsorship (#20) (#25)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2 vercel sponsorship (#20) (#25) (#26)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Update readme

* Update readme

* Update readme

* #18 Refine Header

* #18 Good for now

* Header Nav Component (#32)

* created the header nav component with only logo and home for the first release, the rest of the links will come when those pages have content, also made landing pages for about and conference links, added a breakpoints file to help with media query styling with styled components

* made the requested change from review

* Add and update vercel assets

* Small negative space enhancements

* Defeat Megatron (#34)

* Switch out hero svg for image

* Defeated megatron

* Incredibly unnecessary header styling

* Optimize Footer Image and Header text

* update gitignore

* ope

* Homepage Info Section (#35)

* added the first draft of the info section of the home page and is fairly responsive

* added styling to info cards

* Dev/17 jh info cards (#36)

* Defeat Megatron (#34)

* Switch out hero svg for image

* Defeated megatron

* Incredibly unnecessary header styling

* Small style and copy changes

* Adjust per comments

* Adjust per comments

* Adjust mobile view and justify text

* Somehow enhanced the margins

* Add extra title breakpoint

* I love this breakpoint function - Update subtitle for mobile

* Adjust brightness of jumbotron in a scuffed manner

* Add breakpoint for SubTitle width

Co-authored-by: James He <hejames98@gmail.com>

* First Hotfix. Memories (#42)

Co-authored-by: sdmungov <55511406+sdmungov@users.noreply.github.com>
Co-authored-by: Franco Reda <francoreda95@gmail.com>

* Hotfix/dates change (#56)

* Staging (#43)

* Dev/2 vercel sponsorship (#20) (#25)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2b vercel sponsorship (#31)

* Dev/2 vercel sponsorship (#20) (#21)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2 vercel sponsorship (#20) (#25) (#26)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Update readme

* Update readme

* Update readme

* Release/2021/sprint 1 (#39)

* Dev/2 vercel sponsorship (#20)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2 vercel sponsorship (#20) (#21)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* created the jumbotron component for the landing of the home page and put it in a components folder and imported it into pages/index, set up fonts and colors files and some early global styles but those will be changed over to styled components based off a decision after this code was written (#22)

* installed and set up some basic styled-components, converted parts of jumbotron component and main page ot use some styled components (#24)

* Dev/2 vercel sponsorship (#20) (#25) (#26)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/1 jh deployment rebase (#27)

* Dev/2 vercel sponsorship (#20) (#25) (#26)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* created the jumbotron component for the landing of the home page and put it in a components folder and imported it into pages/index, set up fonts and colors files and some early global styles but those will be changed over to styled components based off a decision after this code was written (#22)

* installed and set up some basic styled-components, converted parts of jumbotron component and main page ot use some styled components (#24)

* Use utm params for vercel redirects

* Readme changes

Co-authored-by: sdmungov <55511406+sdmungov@users.noreply.github.com>

* #18 Initialize New Footer Component
* Add FontAwesome
* Add new footer and associated storybook/styles
* Improved storybook setup

* Dev/2b vercel sponsorship (#30)

* Dev/2 vercel sponsorship (#20) (#21)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2 vercel sponsorship (#20) (#25)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Update readme

* Update readme

* Update readme

* Dev/2b vercel sponsorship (#29)

* Dev/2 vercel sponsorship (#20) (#25)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Dev/2 vercel sponsorship (#20) (#25) (#26)

* Add LICENSE

* Update gitignore

* Update vercel footer

* Add Vercel banner to README

* Add divider for style points

* Update links and copy Deploy on Vercel README section

* Small README adjustment

* Update readme

* Update readme

* Update readme

* #18 Refine Header

* #18 Good for now

* Header Nav Component (#32)

* created the header nav component with only logo and home for the first release, the rest of the links will come when those pages have content, also made landing pages for about and conference links, added a breakpoints file to help with media query styling with styled components

* made the requested change from review

* Add and update vercel assets

* Small negative space enhancements

* Defeat Megatron (#34)

* Switch out hero svg for image

* Defeated megatron

* Incredibly unnecessary header styling

* Optimize Footer Image and Header text

* update gitignore

* ope

* Homepage Info Section (#35)

* added the first draft of the info section of the home page and is fairly responsive

* added styling to info cards

* Dev/17 jh info cards (#36)

* Defeat Megatron (#34)

* Switch out hero svg for image

* Defeated megatron

* Incredibly unnecessary header styling

* Small style and copy changes

* Adjust per comments

* Adjust per comments

* Adjust mobile view and justify text

* Somehow enhanced the margins

* Add extra title breakpoint

* I love this breakpoint function - Update subtitle for mobile

* Adjust brightness of jumbotron in a scuffed manner

* Add breakpoint for SubTitle width

Co-authored-by: James He <hejames98@gmail.com>

* First Hotfix. Memories (#42)

Co-authored-by: sdmungov <55511406+sdmungov@users.noreply.github.com>
Co-authored-by: Franco Reda <francoreda95@gmail.com>

Co-authored-by: sdmungov <55511406+sdmungov@users.noreply.github.com>
Co-authored-by: Franco Reda <francoreda95@gmail.com>

* changes the dates to the correct dates on the homepage

* removed storybook-static

Co-authored-by: James He <hejames98@gmail.com>
Co-authored-by: Franco Reda <francoreda95@gmail.com>

* Dev/55 staff app form (#59)

* added school registration form page and updated nav bar, mobile friendle nav bar to come soon

* school registration form

* Feature/4 school registration (#63)

* staff apps (#61)

* added school registration form page and updated nav bar, mobile friendle nav bar to come soon

* school registration form

* Sort fields by index before rendering

* Add asterisk for required fields

* Remove console log

* Feature/4 school registration (#64)

* staff apps (#61)

* added school registration form page and updated nav bar, mobile friendle nav bar to come soon

* school registration form

* Sort fields by index before rendering

* Add asterisk for required fields

* Remove console log

Co-authored-by: Steven Mungovan <55511406+sdmungov@users.noreply.github.com>
Co-authored-by: sdmungov <stevenmun@yahoo.com>

* added v1.0 of the mobile friendly top nav bar

Co-authored-by: sdmungov <55511406+sdmungov@users.noreply.github.com>
Co-authored-by: Franco Reda <francoreda95@gmail.com>
Co-authored-by: sdmungov <stevenmun@yahoo.com>
Purpose - create a relatively clean environment to make significant
environment updates in this project.

- Removed storybook package and directory;
- Upgrade all dependencies to the most recent compaitble one;
Attempted to standardize file structure format - will continue to do so
after setting up ESLint

* Moved all non-NextJS specific files into a new directory `app`
* Moved `_document.js` file into `pages/`
@vercel
Copy link

vercel bot commented Nov 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/model-un/cimun-web/9zNdBGpapWpwDhSLqEUsttbvhVub
✅ Preview: https://cimun-web-git-feature-add-eslint-and-cleanup-deps-model-un.vercel.app

@he-james he-james requested review from FB-Reda and sdmungov November 24, 2021 05:34
@he-james he-james added the enhancement New feature or request label Nov 24, 2021
@he-james he-james changed the base branch from main to upstream November 24, 2021 05:47
@he-james he-james changed the base branch from upstream to staging November 24, 2021 05:53
@FB-Reda
Copy link
Contributor

FB-Reda commented Jun 20, 2023

Is there anything we still want out of this? I think we're maybe taking a new approach to cleanup and updating so some of it may be less relevant. Additionally merge conflicts on this might be quite difficult.

@FB-Reda FB-Reda self-requested a review July 11, 2023 19:58
Copy link
Contributor

@FB-Reda FB-Reda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants