Change IOrganizer::profile return type to a shared_ptr #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Holt59 this one also needs to be merged for the plugin to work with the uibase changes |
Member
|
@JonathanFeenstra I think you need to update the CI to not use Azure cache for VCPKG. Also, you might want to remake the change while disabling the formatter because this repository is not clang-formatted (to avoid some issue with C++/CLI). |
JonathanFeenstra
force-pushed
the
fix-iorganizer-profile
branch
from
fe7289d to
fddaa3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires ModOrganizer2/modorganizer-uibase#178